kgabryje commented on a change in pull request #13565:
URL: https://github.com/apache/beam/pull/13565#discussion_r549362555
##########
File path: website/www/site/assets/scss/_calendar.scss
##########
@@ -56,11 +56,13 @@
}
}
- .calendar-card-big-left:hover {
- box-shadow: 0 4px 20px 0 rgba(0, 0, 0, 0.24),
- 0 4px 6px 0 rgba(0, 0, 0, 0.24);
+ .calendar-card-big-left {
+ padding: 0 !important;
Review comment:
Could you try to get rid of `!important`s? Maybe add some css class to increase specificity?
##########
File path: website/www/site/assets/scss/lists.scss
##########
@@ -0,0 +1,146 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+@import "media";
+
+.arrow-list {
+ margin-top: 26px;
+ ul {
+ font-size: 16px;
+ font-weight: normal;
+ line-height: 1.63;
+ letter-spacing: 0.43px;
+ position: relative;
+ li:before {
+ content: "\2192";
+ position: absolute;
+ color: #ff6d05;
+ font-size: 24px;
+ line-height: 20px;
+ left: 0;
+ }
+ li {
+ list-style-type: none;
+ list-style-position: outside;
+ margin-bottom: 6px;
+ p {
+ margin: 0;
+ }
+ }
+ }
+}
+.arrow-lists-desktop {
+ margin-top: 36px;
+}
+.arrow-lists-mobile {
+ display: none;
+ .arrow-list-header {
+ font-size: 28px;
+ font-weight: 500;
+ line-height: 1.29;
+ letter-spacing: normal;
+ color: #333333;
+ text-decoration: none;
+ display: flex;
+ img {
+ margin-top: 17px;
+ width: 18px;
+ height: 18px;
+ padding-right: 16px;
+ transform: rotate(-90deg);
+ }
+ }
+ .rotate {
+ img {
+ transform: rotate(0deg);
+ margin-top: 26px;
+ }
+ }
+}
+@media (max-width: $mobile) {
+ .arrow-lists-desktop {
+ display: none;
+ }
+ .arrow-lists-mobile {
+ display: block;
+ }
+}
+pre {
+ background: rgba(255, 109, 0, 0.03);
+ border-radius: 8px;
+ border: solid 0.6px #ff6d05;
+ font-family: Menlo;
+ font-size: 16px;
Review comment:
I think some styles are duplicated with the ones defined in `_global.scss`, like `font-family: Menlo`
##########
File path: website/www/site/content/en/contribute/_index.md
##########
@@ -21,57 +22,65 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-# Apache Beam Contribution Guide
+# Contribution guide
+
+</br>
+
+<div class="arrow-lists-desktop">
+
+## Overview
-The Apache Beam community welcomes contributions from anyone!
+</br>
-If you have questions, please [reach out to the Beam community](/contribute/get-help).
+There are lots of opportunities to contribute. You can for example:
-There are lots of opportunities to contribute:
+<div class="arrow-list">
- - ask or answer questions on [user@beam.apache.org](/community/contact-us/) or
-[stackoverflow](https://stackoverflow.com/questions/tagged/apache-beam)
- - review proposed design ideas on [dev@beam.apache.org](/community/contact-us/)
- - improve the documentation
- - file [bug reports](https://issues.apache.org/jira/projects/BEAM/issues)
- - test releases
- - review [changes](https://github.com/apache/beam/pulls)
- - write new examples
- - improve your favorite language SDK (Java, Python, Go, etc)
- - improve specific runners (Apache Flink, Apache Spark, Google
- Cloud Dataflow, etc)
- - improve or add IO connectors
- - add new transform libraries (statistics, ML, image processing, etc)
- - work on the core programming model (what is a Beam pipeline and how does it
- run?)
- - improve the developer experience (for example, Windows guides)
- - add answers to the [contribution FAQ](
- https://cwiki.apache.org/confluence/display/BEAM/Contributor+FAQ)
- - organize local meetups of users or contributors to Apache Beam
+- ask or answer questions on [user@beam.apache.org](/community/contact-us/) or
+ [stackoverflow](https://stackoverflow.com/questions/tagged/apache-beam)
+- review proposed design ideas on [dev@beam.apache.org](/community/contact-us/)
+- file [bug reports](https://issues.apache.org/jira/projects/BEAM/issues)
+- review [changes](https://github.com/apache/beam/pulls)
+- work on the core programming model (what is a Beam pipeline and how does it
+ run?)
+- improve the developer experience (for example, Windows guides)
+- organize local meetups of users or contributors to Apache Beam
-Most importantly, if you have an idea of how to contribute, then do it!
+</div>
+
+...and many more. Most importantly, if you have an idea of how to contribute, then do it!
+
+</br>
## Contributing code
+</br>
+
Below is a tutorial for contributing code to Beam, covering our tools and typical process in
detail.
+</br>
+
### Prerequisites
-To contribute code, you need
+<div class="arrow-list">
+
+- a GitHub account
+- a Linux, macOS, or Microsoft Windows development environment with Java JDK 8 installed
+- [Docker](https://www.docker.com/) installed for some tasks including building worker containers and testing this website
+ changes locally
+- [Go](https://golang.org) 1.12 or later installed for Go SDK development
+- Python 3.6, 3.7, and 3.8. Yes, you need all four versions installed.
+
+ pip, setuptools, virtualenv, and tox installed for Python development
+
+- for large contributions, a signed [Individual Contributor License
+ Agreement](https://www.apache.org/licenses/icla.pdf) (ICLA) to the Apache
+ Software Foundation (ASF).
- - a GitHub account
- - a Linux, macOS, or Microsoft Windows development environment with Java JDK 8 installed
- - [Docker](https://www.docker.com/) installed for some tasks including building worker containers and testing this website
- changes locally
- - [Go](https://golang.org) 1.12 or later installed for Go SDK development
- - Python 3.6, 3.7, and 3.8. Yes, you need all three versions installed.
- - pip, setuptools, virtualenv, and tox installed for Python development
- - for large contributions, a signed [Individual Contributor License
- Agreement](https://www.apache.org/licenses/icla.pdf) (ICLA) to the Apache
- Software Foundation (ASF).
+</div>
Review comment:
I think that we could remove this div, like @TheNeuralBit requested, by styling `<li>` elements with some wrapper class in `/layouts/contribute/baseof.html`. We could replace
```
<div class="body__contained body__section-nav">
{{ .Content }}
</div>
```
with
```
<div class="body__contained body__section-nav arrow-list">
{{ .Content }}
</div>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org