[jira] [Work logged] (BEAM-5145) Make PTransform names stable in Join/CoGroupByKey

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5145?focusedWorklogId=134439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134439 ]

ASF GitHub Bot logged work on BEAM-5145:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/18 07:39
            Start Date: 14/Aug/18 07:39
    Worklog Time Spent: 10m 
      Work Description: toelen commented on issue #6212: [BEAM-5145] Make PTransform names stable in Join/CoGroupByKey
URL: https://github.com/apache/beam/pull/6212#issuecomment-412782791
 
 
   This is an example of the case we are seeing (in our case with Join and CoGroupByKey). If the setStableUniqueNames call is removed, the test breaks. When adding names in all PTransform.apply calls, the test runs fine again.
   
   ```
   public class Mytest {
       @Rule
       public TestPipeline p = TestPipeline.create();
   
       @Before
       public void setUp() throws Exception {
           p.getOptions().setStableUniqueNames(PipelineOptions.CheckEnabled.OFF);
       }
   
       private static PTransform<PCollection<Integer>, PCollection<Integer>> mytransform() {
           return new PTransform<PCollection<Integer>, PCollection<Integer>>() {
               @Override
               public PCollection<Integer> expand(PCollection<Integer> input) {
                   return input.apply(mytransform2())
                               .apply(mytransform2());
               }
           };
       }
   
       private static PTransform<PCollection<Integer>, PCollection<Integer>> mytransform2() {
           return new PTransform<PCollection<Integer>, PCollection<Integer>>() {
               @Override
               public PCollection<Integer> expand(PCollection<Integer> input) {
                   return input;
               }
           };
       }
   
       @Test
       public void testRecursive() {
           PCollection<Integer> input1 = p.apply(Create.of(1, 2, 3));
           for (int i = 0; i < 3; i++) {
               input1 = input1.apply("my-transform-" + i, mytransform());
           }
           p.run();
       }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 134439)
            Time Spent: 10m
    Remaining Estimate: 0h

> Make PTransform names stable in Join/CoGroupByKey
> -------------------------------------------------
>
>                 Key: BEAM-5145
>                 URL: https://issues.apache.org/jira/browse/BEAM-5145
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Assignee: Leen Toelen
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)