[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1221: Remove explicit simd arithmetic kernels except for division/modulo

[GitBox <gi...@apache.org>]

jhorstmann commented on a change in pull request #1221:
URL: https://github.com/apache/arrow-rs/pull/1221#discussion_r790152266



##########
File path: arrow/src/buffer/immutable.rs
##########
@@ -153,6 +153,7 @@ impl Buffer {
     ///
     /// Note that this should be used cautiously, and the returned pointer should not be
     /// stored anywhere, to avoid dangling pointers.
+    #[inline]

Review comment:
       This did not get inlined in one of my benchmarks, which is weird for such a short method. I think it only gets called by a chain of methods marked as `inline`, so maybe that confused the compiler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org