You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/07/07 17:40:38 UTC
svn commit: r1879602 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java
Author: tilman
Date: Tue Jul 7 17:40:38 2020
New Revision: 1879602
URL: http://svn.apache.org/viewvc?rev=1879602&view=rev
Log:
PDFBOX-4907: avoid reusing all type of field names, not just signature ones
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java?rev=1879602&r1=1879601&r2=1879602&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureField.java Tue Jul 7 17:40:38 2020
@@ -19,6 +19,7 @@ package org.apache.pdfbox.pdmodel.intera
import java.io.IOException;
import java.util.HashSet;
import java.util.Set;
+import java.util.stream.Stream;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -73,16 +74,10 @@ public class PDSignatureField extends PD
private String generatePartialName()
{
String fieldName = "Signature";
- Set<String> sigNames = new HashSet<>();
- for (PDField field : getAcroForm().getFieldTree())
- {
- if(field instanceof PDSignatureField)
- {
- sigNames.add(field.getPartialName());
- }
- }
+ Set<String> nameSet = new HashSet<>();
+ getAcroForm().getFieldTree().forEach(field -> nameSet.add(field.getPartialName()));
int i = 1;
- while(sigNames.contains(fieldName+i))
+ while (nameSet.contains(fieldName + i))
{
++i;
}