[GitHub] [netbeans] junichi11 commented on a diff in pull request #4037: [NETBEANS-5523] PHP 8.0: Treat namespaced names as single token

[GitBox <gi...@apache.org>]

junichi11 commented on code in PR #4037:
URL: https://github.com/apache/netbeans/pull/4037#discussion_r880335809


##########
php/php.editor/src/org/netbeans/modules/php/editor/parser/astnodes/NamespaceName.java:
##########
@@ -64,6 +70,24 @@ public NamespaceName(int start, int end, List segments, boolean global, boolean
         this.current = current;
     }
 
+    @NonNull
+    public static NamespaceName create(int start, int end, @NonNull String namespaceName) {
+        boolean isGlobal = namespaceName.startsWith("\\"); // NOI18N
+        boolean isCurrent = namespaceName.startsWith("namespace\\"); // NOI18N
+        String[] names = namespaceName.split("\\\\"); // NOI18N
+        int startSegment = start;
+        List<Identifier> list = new ArrayList<>();

Review Comment:
   Will fix it next time :) Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists