You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Jonathan D. Knezek (JIRA)" <ji...@apache.org> on 2010/08/03 22:42:16 UTC
[jira] Created: (COUCHDB-842) Add JSON POST support to /_session
Add JSON POST support to /_session
----------------------------------
Key: COUCHDB-842
URL: https://issues.apache.org/jira/browse/COUCHDB-842
Project: CouchDB
Issue Type: Improvement
Components: HTTP Interface
Affects Versions: 1.0
Reporter: Jonathan D. Knezek
Priority: Minor
Attachments: 0001-Add-JSON-POST-support-to-_session.patch
With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Jonathan D. Knezek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan D. Knezek updated COUCHDB-842:
---------------------------------------
Attachment: 0001-Add-JSON-POST-support-to-_session-3.patch
0002-Change-couch.js-to-POST-JSON-to-_session.patch
Added a test case and an optional patch that makes couch.js take advantage of the new functionality
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session-2.patch, 0001-Add-JSON-POST-support-to-_session-3.patch, 0001-Add-JSON-POST-support-to-_session.patch, 0002-Change-couch.js-to-POST-JSON-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Jonathan D. Knezek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895056#action_12895056 ]
Jonathan D. Knezek commented on COUCHDB-842:
--------------------------------------------
I'll have to tackle the test on another machine later as neither my Windows dev box (woe is me) nor my Linux Mint VM can pass the cookie_auth test with stock 1.0.0
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session-2.patch, 0001-Add-JSON-POST-support-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Jonathan D. Knezek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan D. Knezek updated COUCHDB-842:
---------------------------------------
Attachment: 0001-Add-JSON-POST-support-to-_session.patch
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895040#action_12895040 ]
Filipe Manana commented on COUCHDB-842:
---------------------------------------
Hi Jonathan,
The patch looks good.
However, one thing it must have is a test (look into share/www/script/tests/*.js)
I would also prefer if:
- it uses the macro ?b2l instead of binary_to_list/1 (makes code more readable)
- it uses macro ?JSON_DECODE instead of couch_util:json_decode/1
Can you do it?
cheers
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana closed COUCHDB-842.
---------------------------------
Resolution: Fixed
Applied to trunk (revision 982200).
Thanks Jonathan.
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session-2.patch, 0001-Add-JSON-POST-support-to-_session-3.patch, 0001-Add-JSON-POST-support-to-_session.patch, 0002-Change-couch.js-to-POST-JSON-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-842) Add JSON POST support to /_session
Posted by "Jonathan D. Knezek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan D. Knezek updated COUCHDB-842:
---------------------------------------
Attachment: 0001-Add-JSON-POST-support-to-_session-2.patch
Revised to use common macros
> Add JSON POST support to /_session
> ----------------------------------
>
> Key: COUCHDB-842
> URL: https://issues.apache.org/jira/browse/COUCHDB-842
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface
> Affects Versions: 1.0
> Reporter: Jonathan D. Knezek
> Priority: Minor
> Attachments: 0001-Add-JSON-POST-support-to-_session-2.patch, 0001-Add-JSON-POST-support-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.