You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/23 16:41:49 UTC

[GitHub] [spark] gengliangwang commented on pull request #35855: [SPARK-38336][SQL] Support DEFAULT column values in CREATE/REPLACE TABLE and INSERT INTO statements

gengliangwang commented on pull request #35855:
URL: https://github.com/apache/spark/pull/35855#issuecomment-1076518389


   @dtenedor this PR looks good overall. 
   However, it is quite big and it takes effort to review it carefully.
   Do you mind splitting it into two PRs? One for creating tables and another one for inserting into.
   I am pretty sure the create table one can be merged very soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org