You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2014/12/10 17:09:12 UTC
[jira] [Commented] (HBASE-12668) Adapt PayloadCarryingRpcController
so it can also be used in async way
[ https://issues.apache.org/jira/browse/HBASE-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241302#comment-14241302 ]
stack commented on HBASE-12668:
-------------------------------
Patch seems good.
Next version, fix this:
61 if(exception != null){
62 return exception.getMessage();
63 }else{
64 return null;
65 }
Make it so has same style as rest of the code (see space after closing parens. Your checkstyle report will have complaints about them.
> Adapt PayloadCarryingRpcController so it can also be used in async way
> ----------------------------------------------------------------------
>
> Key: HBASE-12668
> URL: https://issues.apache.org/jira/browse/HBASE-12668
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Jurriaan Mous
> Assignee: Jurriaan Mous
> Attachments: HBASE-12668.patch
>
>
> With the changes in HBASE-12597 it is possible to create a new RPC client. But in all places the BlockingRpcChannel is called with a PayloadCarryingRpcController. This controller is not usable in Async context because some methods are not supported at the moment. (See TimeLimitedRpcController for the methods that throw UnsupportedOperationException)
> This issue is about implementing these methods so PayloadCarryingRpcController can also be used in an async context and work the same in a sync context.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)