[GitHub] [ozone] sodonnel commented on a diff in pull request #3275: HDDS-6554. Have the datanode heartbeat include queued command counts

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3275:
URL: https://github.com/apache/ozone/pull/3275#discussion_r846359076


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteContainerCommandHandler.java:
##########
@@ -82,6 +82,11 @@ public void handle(final SCMCommand command,
     });
   }
 
+  @Override
+  public int getQueuedCount() {

Review Comment:
   You could be right. For replicate container command, it uses a slightly different implementation, so it does return the count of running + queued. However for others that use executors, the true queued work will be the queue_size + currently executing. However it will always be changing and will be out-of-date almost as soon as it arrives at SCM. I guess the queue size is a good approximation, but perhaps we should open another Jira to investigate making this more accurate in the future. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org