You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/10/26 09:01:06 UTC
[GitHub] [dolphinscheduler-website] zhongjiajie opened a new pull request #474: Add website 2.0 release
zhongjiajie opened a new pull request #474:
URL: https://github.com/apache/dolphinscheduler-website/pull/474
This patch we release DolphinScheduler 2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #474: Add website 2.0 release
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #474:
URL: https://github.com/apache/dolphinscheduler-website/pull/474#discussion_r736314768
##########
File path: src/pages/docs/index.md.jsx
##########
@@ -56,7 +58,13 @@ class Docs extends Md2Html(Language) {
dataSource = docsSource[siteConfig.docsLatest][language];
dataSource.sidemenu.forEach((menu) => {
menu.children.forEach((submenu) => {
- submenu.link = submenu.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ if (!submenu.children) {
+ submenu.link = submenu.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ } else {
+ submenu.children.forEach((menuLevel3) => {
+ menuLevel3.link = menuLevel3.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ })
+ }
Review comment:
The origin setting do not support three level menu, and I temp add some code to make it work, could some take a look at it? cc: @chengshiwen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #474: Add website 2.0 release
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #474:
URL: https://github.com/apache/dolphinscheduler-website/pull/474#discussion_r736314768
##########
File path: src/pages/docs/index.md.jsx
##########
@@ -56,7 +58,13 @@ class Docs extends Md2Html(Language) {
dataSource = docsSource[siteConfig.docsLatest][language];
dataSource.sidemenu.forEach((menu) => {
menu.children.forEach((submenu) => {
- submenu.link = submenu.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ if (!submenu.children) {
+ submenu.link = submenu.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ } else {
+ submenu.children.forEach((menuLevel3) => {
+ menuLevel3.link = menuLevel3.link.replace(`docs/${siteConfig.docsLatest}`, 'docs/latest');
+ })
+ }
Review comment:
The origin setting only support two level menu, but our latest doc menu have more than two
So I temp add some code to make it work for three level menu, could some take a look at it? cc: @chengshiwen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] CalvinKirs merged pull request #474: Add website 2.0 release
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #474:
URL: https://github.com/apache/dolphinscheduler-website/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org