You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Maik Richey (JIRA)" <ji...@codehaus.org> on 2010/11/08 21:29:03 UTC
[jira] Created: (MASSEMBLY-528) FileSet does not support filtering
(again)
FileSet does not support filtering (again)
------------------------------------------
Key: MASSEMBLY-528
URL: http://jira.codehaus.org/browse/MASSEMBLY-528
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2
Reporter: Maik Richey
Priority: Critical
After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256939#action_256939 ]
Olivier Lamy commented on MASSEMBLY-528:
----------------------------------------
go for an other release :-)
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: John Casey
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Marc Rohlfs (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=248898#action_248898 ]
Marc Rohlfs commented on MASSEMBLY-528:
---------------------------------------
As I already mentioned, the filters are taken from the project if there's at least one filter defined in the plugin configuration. This also works if the plugin configuration contains an empty filter node. This means that the workaround can be introduced globally in the plugin management section (of the/a parent POM):
{code:xml}
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<version>2.2</version>
<configuration>
<filters>
<filter></filter>
</filters>
</configuration>
</plugin>
</plugins>
</pluginManagement>
{code}
There's also a workaround for the filtering problem that occurs when the file to be filtered contains an @ sign: Just care that the file contains an even number of @ signs. This might sound a little crazy, but it seems to work - guess it's because old style filter tokens started and ended with an @ sign.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Priority: Critical
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-528) FileSet does not support filtering
(again)
Posted by "Marc Rohlfs (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc Rohlfs updated MASSEMBLY-528:
----------------------------------
Attachment: MASSEMBLY-528_sample.zip
This sample show several problems/behaviours:
# Filters *are not* taken from the project if no filters are define in the plugin configuration.
# Filters *are* taken from the project if there's any filter defined in the plugin configuration.
# Filtering doesn't work if the file to be filtered contains an {{@}} sign.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Priority: Critical
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "David Delbecq (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=264297#action_264297 ]
David Delbecq commented on MASSEMBLY-528:
-----------------------------------------
Please reopen the issue, it is still broken.
If a line in the fitlered file starts with an @, the line is not filtered.
my source batch file:
example ${pom.version}
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i get:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i expect:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-1.0-SNAPSHOT.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The workaround:
replace all @ with ${At} and put in filters: At=@
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256932#action_256932 ]
Benjamin Bentmann commented on MASSEMBLY-528:
---------------------------------------------
Good catch Dennis, you're right, the {{MavenProject}} instance shouldn't be altered here.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: John Casey
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-528) FileSet does not
support filtering (again)
Posted by "David Delbecq (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=264297#action_264297 ]
David Delbecq edited comment on MASSEMBLY-528 at 4/21/11 5:21 AM:
------------------------------------------------------------------
Please reopen the issue, it is still broken.
If a line in the fitlered file starts with an @, the line is not filtered.
{noformat}
my source batch file:
example ${pom.version}
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i get:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i expect:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-1.0-SNAPSHOT.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The workaround:
replace all @ with ${At} and put in filters: At=@
{noformat}
was (Author: tchize):
Please reopen the issue, it is still broken.
If a line in the fitlered file starts with an @, the line is not filtered.
my source batch file:
example ${pom.version}
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i get:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-${pom.version}.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The output i expect:
example 1.0-SNAPSHOT
@java -jar .\lib\dvp-latexrenderer-1.0-SNAPSHOT.jar .\..\documents\%1\%1.xml .\..\documents\%1\%1-latex.xml images
The workaround:
replace all @ with ${At} and put in filters: At=@
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MASSEMBLY-528) FileSet does not
support filtering (again)
Posted by "Gérald Quintana (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=245612#action_245612 ]
Gérald Quintana edited comment on MASSEMBLY-528 at 11/29/10 2:12 AM:
---------------------------------------------------------------------
This a regression between 2.2-beta-5 and 2.2
Workaround: Filters are not taken from project but you can force it like this:
{code:xml}
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<configuration>
<filters>
<filter>../src/main/filters/filter-${env}.properties</filter>
</filters>
<descriptors>
<descriptor>src/main/assembly/descriptor.xml</descriptor>
</descriptors>
</configuration>
</plugin>
{code}
was (Author: gquintana):
This a regression between 2.2-beta-5 and 2.2
Workaround: Filters are taken from project but you can force it like this:
{code:xml}
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<configuration>
<filters>
<filter>../src/main/filters/filter-${env}.properties</filter>
</filters>
<descriptors>
<descriptor>src/main/assembly/descriptor.xml</descriptor>
</descriptors>
</configuration>
</plugin>
{code}
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Priority: Critical
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Gérald Quintana (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=245612#action_245612 ]
Gérald Quintana commented on MASSEMBLY-528:
-------------------------------------------
This a regression between 2.2-beta-5 and 2.2
Workaround: Filters are taken from project but you can force it like this:
{code:xml}
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<configuration>
<filters>
<filter>../src/main/filters/filter-${env}.properties</filter>
</filters>
<descriptors>
<descriptor>src/main/assembly/descriptor.xml</descriptor>
</descriptors>
</configuration>
</plugin>
{code}
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Priority: Critical
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-528) FileSet does not support filtering
(again)
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-528:
---------------------------------
Fix Version/s: 2.2.1
Assignee: John Casey
I'll try to get this one fixed for 2.2.1 as well.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: John Casey
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=256931#action_256931 ]
Dennis Lundberg commented on MASSEMBLY-528:
-------------------------------------------
Thanks for the sample project Marc!
Background on versions
Assembly plugin 2.2-beta-5 uses maven-filtering 1.0-beta-2,
Assembly Plugin 2.2 uses maven-filtering 1.0-beta-4.
The problem
When filtering more than one file, only the first file is filtered. This is highlighted by the sample project. Look at the file target\MASSEMBLY-528-1.0-SNAPSHOT_without-assembly-filter\filtered.properties after the build. It has not had the value for ${filter.build} injected.
The cause
In [r809265|http://svn.apache.org/viewvc?view=revision&revision=809265] the following change was made to the file DefaultMavenFileFilter in maven-filtering.
r806294
{code}
loadProperties( filterProperties, mavenProject.getBuild().getFilters(), baseProps );
{code}
r809265
{code}
if ( request.isInjectProjectBuildFilters() )
{
List buildFilters = request.getMavenProject().getBuild().getFilters();
buildFilters.removeAll( request.getFileFilters() );
loadProperties( filterProperties, buildFilters, baseProps );
}
{code}
What happens here is that filters are removed from the MavenProject. So after this code has been called the first time, to actual Maven Project has changed! My tests so far indicate that in a project where only build/filters are used they all gets nuked by this, resulting in only the first file being filtered.
Solution
Making sure that we work on a copy of the project's filters like this:
{code}
List buildFilters = new ArrayList(request.getMavenProject().getBuild().getFilters());
{code}
Comments and feedback are most welcome.
I have integration tests in the works for the Assembly Plugin.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: John Casey
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-528) FileSet does not support filtering
(again)
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MASSEMBLY-528.
-------------------------------------
Resolution: Fixed
Assignee: Dennis Lundberg (was: John Casey)
After the fix for MSHARED-188, this now works for me.
In [r1072643|http://svn.apache.org/viewvc?view=revision&revision=1072643] I added an integration test based on Marc's sample project. That IT now passes.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=264327#action_264327 ]
Dennis Lundberg commented on MASSEMBLY-528:
-------------------------------------------
David,
You have a different problem than the one covered in this issue.
Please open a new issue and attach a complete test project that we can use to verify your problem.
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Assignee: Dennis Lundberg
> Priority: Critical
> Fix For: 2.2.1
>
> Attachments: MASSEMBLY-528_sample.zip
>
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-528) FileSet does not support
filtering (again)
Posted by "Matthieu Scholler (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244552#action_244552 ]
Matthieu Scholler commented on MASSEMBLY-528:
---------------------------------------------
I confirm, same behaviour here, filtering in a fileset is broken for 2.2 (using some other beta instead).
> FileSet does not support filtering (again)
> ------------------------------------------
>
> Key: MASSEMBLY-528
> URL: http://jira.codehaus.org/browse/MASSEMBLY-528
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2
> Reporter: Maik Richey
> Priority: Critical
>
> After switching to version 2.2 of the Assembly Plugin filtering for FileSets does not work again as in versions prior to 2.2-beta-3.
> Can anybody confirm this issue?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira