You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/14 23:11:20 UTC
[GitHub] [couchdb-fauxton] garbados opened a new pull request #1312: feat: change partition option to checkbox
garbados opened a new pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
Pursuant to https://github.com/apache/couchdb-fauxton/issues/1282 this PR changes the partition option to a checkbox.
Unfortunately I am not particularly familiar with this codebase, so this is a best-effort attempt. I was unable to test it myself.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## GitHub issue number
<!-- If this is a significant change, please file a separate issue at:
https://github.com/apache/couchdb-fauxton/issues
and include the number here and in commit message(s) using
syntax like "Fixes #472" or "Fixes apache/couchdb#472". -->
## Related Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those pull requests here. -->
- https://github.com/apache/couchdb-fauxton/issues/1282
## Checklist
- [ ] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] janl merged pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
janl merged pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] garbados commented on pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
garbados commented on pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312#issuecomment-799775288
Thanks for the feedback! I have incorporated the changes you outlined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] brianewilkins commented on pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
brianewilkins commented on pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312#issuecomment-801872587
I think adding a gap between the "Database name" text field and the "Partitioned Database?" checkbox makes it look better.
That is, to change lines 90 to 97 of ./app/addons/databases/assets/less/databases.less.orig from:
```
.partitioned-db-options {
display: flex;
align-items: baseline;
input {
margin: 0px 10px 0px 0px;
}
}
```
to:
```
.partitioned-db-options {
display: flex;
align-items: baseline;
padding-top: 1rem;
input {
margin: 0px 10px 0px 0px;
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] brianewilkins edited a comment on pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
brianewilkins edited a comment on pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312#issuecomment-801872587
I think adding a gap between the "Database name" text field and the "Partitioned Database?" checkbox makes it look better.
That is, to change lines 90 to 97 of ./app/addons/databases/assets/less/databases.less from:
```
.partitioned-db-options {
display: flex;
align-items: baseline;
input {
margin: 0px 10px 0px 0px;
}
}
```
to:
```
.partitioned-db-options {
display: flex;
align-items: baseline;
padding-top: 1rem;
input {
margin: 0px 10px 0px 0px;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] brianewilkins commented on pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
brianewilkins commented on pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312#issuecomment-799751371
It did not compile for me.
After I made the following changes it would compile for me.
```
$ diff ./app/addons/databases/components.js.orig ./app/addons/databases/components.js
324,325c324
< this.onSetPartitioned = this.onSetPartitioned.bind(this);
< this.onSetNotPartitioned = this.onSetNotPartitioned.bind(this);
---
> this.onTogglePartitioned = this.onTogglePartitioned.bind(this);
393,395d391
< <label htmlFor="partitioned-db" className='partitioned-db-label'>
< Partitioning
< </label>
403c399
< <label htmlFor="partitioned-db">Partitioned</label>
---
> <label htmlFor="partitioned-db">Partitioned Database?</label>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-fauxton] brianewilkins commented on pull request #1312: feat: change partition option to checkbox
Posted by GitBox <gi...@apache.org>.
brianewilkins commented on pull request #1312:
URL: https://github.com/apache/couchdb-fauxton/pull/1312#issuecomment-799765317
I also found that unless these lines 358 to 365 of ./app/addons/databases/components.js are removed there is an error message when one tries to create a non-partitioned database:
```
if (this.props.showPartitionedOption && this.state.partitionedSelected === undefined) {
FauxtonAPI.addNotification({
type: 'error',
msg: 'Please select either Partitioned or Non-partitioned',
clear: true
});
return;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org