You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/09/27 14:45:57 UTC
[GitHub] [jackrabbit-oak] kwin opened a new pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
kwin opened a new pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376
name
@anchela @mreutegg Any idea why this is failing for the namespace prefix "rep"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin commented on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-947397823
It seems to work only for test cases extending [AbstractJCRTest](https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/AbstractJCRTest.java#L476) (and therefore leveraging https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/JCRTestResult.java#L103) but not for ones extending [AbstractRepositoryTest](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/AbstractRepositoryTest.java) as the latter does not implement this filtering logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin edited a comment on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-947397823
It seems to work only for test cases extending [AbstractJCRTest, JUnit3](https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/AbstractJCRTest.java#L476) (and therefore leveraging https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/JCRTestResult.java#L103) but not for ones extending [AbstractRepositoryTest, JUnit4](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/AbstractRepositoryTest.java) as the latter does not implement this filtering logic. This would require a custom [TestRule](https://junit.org/junit4/javadoc/4.12/org/junit/rules/TestRule.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
mreutegg commented on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-937700312
Meanwhile discussion continued in OAK-9584. Issue is caused by invalid namespace URI as mentioned in OAK-74.
@kwin do you want to keep this PR open? You could add the test to the list of known issues in https://github.com/apache/jackrabbit-oak/blob/403801af2ccf727880019c18efefe95b83fdc3ae/oak-jcr/pom.xml#L38 and then merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin merged pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin merged pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin edited a comment on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-947397823
It seems to work only for test cases extending [AbstractJCRTest, JUnit3](https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/AbstractJCRTest.java#L476) (and therefore leveraging https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/JCRTestResult.java#L103) but not for ones extending [AbstractRepositoryTest, JUnit4](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/AbstractRepositoryTest.java) as the latter does not implement this filtering logic. This would require a custom [TestRule](https://junit.org/junit4/javadoc/4.12/org/junit/rules/TestRule.html) (similar to http://www.javabyexamples.com/conditional-ignore-with-junit-test-rule)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin edited a comment on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin edited a comment on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-947397823
It seems to work only for test cases extending [AbstractJCRTest, JUnit3](https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/AbstractJCRTest.java#L476) (and therefore leveraging https://github.com/apache/jackrabbit/blob/ed3124e5fe223dada33ce6ddf53bc666063c3f2f/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/JCRTestResult.java#L103) but not for ones extending [AbstractRepositoryTest, JUnit4](https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/AbstractRepositoryTest.java) as the latter does not implement this filtering logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] mreutegg commented on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
mreutegg commented on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-937700312
Meanwhile discussion continued in OAK-9584. Issue is caused by invalid namespace URI as mentioned in OAK-74.
@kwin do you want to keep this PR open? You could add the test to the list of known issues in https://github.com/apache/jackrabbit-oak/blob/403801af2ccf727880019c18efefe95b83fdc3ae/oak-jcr/pom.xml#L38 and then merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] kwin commented on pull request #376: OAK-9584 add failing test when accessing rep:authorizableId via expanded
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #376:
URL: https://github.com/apache/jackrabbit-oak/pull/376#issuecomment-947387590
@mreutegg Where is the Maven property `known.issues` (passed as system property to maven-surefire-plugin and maven-failsafe-plugin) evaluated? Despite adding my test method to this property it is still evaluated: https://ci-builds.apache.org/blue/organizations/jenkins/Jackrabbit%2Foak-trunk-pr/detail/PR-376/4/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org