You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/09 23:38:22 UTC
[GitHub] [arrow] wesm opened a new pull request #7389: ARROW-9075: [C++][CI] Fix Windows build
wesm opened a new pull request #7389:
URL: https://github.com/apache/arrow/pull/7389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7389: ARROW-9075: [C++][CI] Fix Windows build
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7389:
URL: https://github.com/apache/arrow/pull/7389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #7389: ARROW-9075: [C++][CI] Fix Windows build
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #7389:
URL: https://github.com/apache/arrow/pull/7389#discussion_r437792823
##########
File path: cpp/src/arrow/util/bit_block_counter_test.cc
##########
@@ -246,5 +246,28 @@ TEST(TestBinaryBitBlockCounter, NextAndWord) {
}
}
+TEST(TestOptionalBitBlockCounter, Basics) {
+ const int64_t nbytes = 1024;
+ auto bitmap = *AllocateBitmap(nbytes * 8);
+ random_bytes(nbytes, 0, bitmap->mutable_data());
+
+ OptionalBitBlockCounter optional_counter(bitmap, 0, nbytes * 8);
+ BitBlockCounter bit_counter(bitmap->data(), 0, nbytes * 8);
+
+ while (true) {
Review comment:
I think do/while here might be more natural?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7389: ARROW-9075: [C++][CI] Fix Windows build
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7389:
URL: https://github.com/apache/arrow/pull/7389#issuecomment-641650598
I didn't mean to open this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org