You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2021/08/08 12:15:27 UTC

svn commit: r1892110 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java

Author: lehmi
Date: Sun Aug  8 12:15:26 2021
New Revision: 1892110

URL: http://svn.apache.org/viewvc?rev=1892110&view=rev
Log:
PDFBOX-5254: preserve a possible indirect object reference

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java?rev=1892110&r1=1892109&r2=1892110&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/AppearanceGeneratorHelper.java Sun Aug  8 12:15:26 2021
@@ -28,6 +28,7 @@ import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.fontbox.util.BoundingBox;
 import org.apache.pdfbox.contentstream.operator.Operator;
+import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.cos.COSString;
 import org.apache.pdfbox.pdfparser.PDFStreamParser;
@@ -150,6 +151,10 @@ class AppearanceGeneratorHelper
             {
                 continue;
             }
+            COSDictionary widgetFontDict = widgetResources.getCOSObject()
+                    .getCOSDictionary(COSName.FONT);
+            COSDictionary acroFormFontDict = acroFormResources.getCOSObject()
+                    .getCOSDictionary(COSName.FONT);
             for (COSName fontResourceName : widgetResources.getFontNames())
             {
                 try
@@ -157,7 +162,9 @@ class AppearanceGeneratorHelper
                     if (acroFormResources.getFont(fontResourceName) == null)
                     {
                         LOG.debug("Adding font resource " + fontResourceName + " from widget to AcroForm");
-                        acroFormResources.put(fontResourceName, widgetResources.getFont(fontResourceName));
+                        // use the COS-object to preserve a possible indirect object reference
+                        acroFormFontDict.setItem(fontResourceName,
+                                widgetFontDict.getItem(fontResourceName));
                     }
                 }
                 catch (IOException e)