[PR] Improve argument validation for approx_most_frequent function [iotdb]

["FearfulTomcat27 (via GitHub)" <gi...@apache.org>]

FearfulTomcat27 opened a new pull request, #15679:
URL: https://github.com/apache/iotdb/pull/15679

   This pull request refines the validation logic for the `approx_most_frequent` function in the SQL parser. The primary change ensures that the second and third arguments are explicitly validated as positive integer literals, improving clarity and correctness.
   
   ### Validation improvements for function arguments:
   * In `AstBuilder.java`, updated the validation logic for the `approx_most_frequent` function to check that the second and third arguments are positive integer literals (`LongLiteral`) when three arguments are provided. This replaces the previous generic numeric literal check.
   
   * Removed the `isNumericLiteral` helper method, as it is no longer used following the updated validation logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improve argument validation for approx_most_frequent function [iotdb]

["JackieTien97 (via GitHub)" <gi...@apache.org>]

JackieTien97 merged PR #15679:
URL: https://github.com/apache/iotdb/pull/15679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org