You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/01 03:03:25 UTC
[GitHub] [arrow] kou commented on a diff in pull request #37412: GH-37410: [C++][Gandiva] Add support for using LLVM shared library
kou commented on code in PR #37412:
URL: https://github.com/apache/arrow/pull/37412#discussion_r1312481501
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -470,6 +470,16 @@ takes precedence over ccache if a storage backend is configured" ON)
"Rely on jemalloc shared libraries where relevant"
${ARROW_DEPENDENCY_USE_SHARED})
+ if(MSVC)
+ # It seems that conda's llvmdev for Windows doesn't provide shared
+ # library.
+ set(ARROW_LLVM_USE_SHARED_DEFAULT OFF)
Review Comment:
It seems that LLVM itself doesn't support shared library on Windows: https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-shlib/CMakeLists.txt#L14-L16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org