You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/17 20:58:00 UTC
[GitHub] [airflow] kaxil opened a new pull request #7752: [AIRFLOW-7074] Add
Permissions to view SubDAGs
kaxil opened a new pull request #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752
There is no granular permission for SubDags at all.
Currently the only time you would be able to view SubDAGs would be when you can view all DAGs.
So even though a user might have the permission to view a DAG, they won't be able to view SubDag
I am not sure the reason why SubDags were excluded originally
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feng-tao commented on issue #7752: [AIRFLOW-7074] Add
Permissions to view SubDAGs
Posted by GitBox <gi...@apache.org>.
feng-tao commented on issue #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752#issuecomment-600299220
I forgot as well....I guess by that time subdag is pretty buggy and there is a trend that we would like to get rid of subdag?But it seems that we improve subdag a lot, so it makes sense to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7752: [AIRFLOW-7074] Add
Permissions to view SubDAGs
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7752: [AIRFLOW-7074] Add
Permissions to view SubDAGs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752#issuecomment-600325832
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=h1) Report
> Merging [#7752](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4979e5ce2fe11df963882db32c2ad394eaf53b58&el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7752/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7752 +/- ##
==========================================
- Coverage 86.99% 86.68% -0.32%
==========================================
Files 915 915
Lines 44198 44198
==========================================
- Hits 38452 38311 -141
- Misses 5746 5887 +141
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/security.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvc2VjdXJpdHkucHk=) | `91.50% <ø> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0.00%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7752/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.73% <0.00%> (-0.15%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=footer). Last update [4979e5c...278bdcb](https://codecov.io/gh/apache/airflow/pull/7752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7752: [AIRFLOW-7074] Add
Permissions to view SubDAGs
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752#issuecomment-600299706
> I forgot as well....I guess by that time subdag is pretty buggy and there is a trend that we would like to get rid of subdag?But it seems that we improve subdag a lot, so it makes sense to do this.
👍 Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services