You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/25 22:18:30 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Ouss4 opened a new pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978
## Summary
Create a different API to initialize all of the extra heaps. This will allow the usage of any of those heap for other purposes than loading code.
## Impact
ESP32 and ESP32-C3 only for now. Could be applied to STM32s and their CCM/TCM heap.
## Testing
esp32-devkitc:elf esp32-devkitc:module esp32-devkitc:sotest
esp32c3-devkit:elf esp32c3-devkit:module esp32c3-devkit:sotest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978#discussion_r659147835
##########
File path: arch/Kconfig
##########
@@ -259,9 +259,17 @@ config ARCH_NEED_ADDRENV_MAPPING
bool
default n
+config ARCH_HAVE_EXTRA_HEAPS
+ bool
+ default n
+ ---help---
+ Special memory regions used as separate heaps
+
config ARCH_HAVE_TEXT_HEAP
- bool "Special memory region for dynamic code loading"
+ bool
default n
Review comment:
should we select ARCH_HAVE_EXTRA_HEAPS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978#issuecomment-868861965
@yamt this requires `CONFIG_ESP32_IRAM_HEAP` (or `CONFIG_ESP32_RTC_HEAP`) to be added to ESP32 configs that use dynamic loading. I tried to avoid this by keeping the IRAM heap conditioned only by `ARCH_USE_TEXT_HEAP` but didn't look to clean to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978#issuecomment-868861965
@yamt this requires `CONFIG_ESP32_IRAM_HEAP` (or `CONFIG_ESP32_RTC_HEAP) to be added to ESP32 configs that use dynamic loading. I tried to avoid this by keeping the IRAM heap conditioned only by `ARCH_USE_TEXT_HEAP` but didn't look to clean to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3978: Decouple the initialization of the separate heaps from the TEXT_HEAP option.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #3978:
URL: https://github.com/apache/incubator-nuttx/pull/3978#discussion_r659156947
##########
File path: arch/Kconfig
##########
@@ -259,9 +259,17 @@ config ARCH_NEED_ADDRENV_MAPPING
bool
default n
+config ARCH_HAVE_EXTRA_HEAPS
+ bool
+ default n
+ ---help---
+ Special memory regions used as separate heaps
+
config ARCH_HAVE_TEXT_HEAP
- bool "Special memory region for dynamic code loading"
+ bool
default n
Review comment:
This won't work well with SoCs that don't have an extra heap but just offset the buffer gotten from simple malloc. Like [CXD56](https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/cxd56xx/cxd56_textheap.c#L50-L80). Part of what I did here is to be able to remove that `up_textheap_init` function when it's not required. (The term `textheap` could be a bit misleading here though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org