You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/07 10:03:08 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #6293: fix sql support doc
jingshanglu opened a new pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293
fix sql support doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r454096713
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
### 不支持的SQL
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------ | -------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES语句不支持运算表达式 |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | 包含schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 详见DISTINCT支持情况详细说明 |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | 会导致全路由 |
+| (SELECT * FROM tbl_name) | 暂不支持加括号的查询 |
+| SELECT MAX(tbl_name.col1) FROM tbl_name | projection中在函数中需要使用表别名引用查询列 |
Review comment:
My concern is that your expression is for users, for whom it is the first and vital guideline, IMO. So please be careful with this document. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r451905846
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_alias.col1 from tbl_name tbl_alias where tbl_alias.col2=?) subquery_alias | |
### 不支持的SQL
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------ | -------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES语句不支持运算表达式 |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | 包含schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 详见DISTINCT支持情况详细说明 |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | 会导致全路由 |
+| (SELECT * FROM tbl_name) | 暂不支持加括号的查询 |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias| 子查询中projection, where 中column 包含table,没有使用table别名 |
Review comment:
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r454114445
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
Review comment:
this one is supported sql.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r451486926
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -149,5 +150,4 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------- |----------------------------------- |
-| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 同时使用普通聚合函数和DISTINCT聚合函数 |
-
+| SELECT SUM(DISTINCT tbl_name.col1), SUM(tbl_name.col1) FROM tbl_name | Use column owner that is not table alias |
Review comment:
Please express this one in Chinese.
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_alias.col1 from tbl_name tbl_alias where tbl_alias.col2=?) subquery_alias | |
### 不支持的SQL
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------ | -------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES语句不支持运算表达式 |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | 包含schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 详见DISTINCT支持情况详细说明 |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | 会导致全路由 |
+| (SELECT * FROM tbl_name) | 暂不支持加括号的查询 |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias| 子查询中projection, where 中column 包含table,没有使用table别名 |
Review comment:
> 子查询中projection, where 中column 包含table,没有使用table别名
子查询的SELECT中的查询列和WHERE条件中查询列包含表名，但没有使用表别名
My understanding is correct, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r454197425
##########
File path: docs/document/content/features/sharding/use-norms/sql.en.md
##########
@@ -110,19 +110,20 @@ When shardingColumn in expressions and functions, ShardingSphere will use full r
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
### Unsupported SQL
| SQL | Reason |
| ------------------------------------------------------------------------------------------ | --------------------------------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES clause does not support operation expression |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | Contain schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | See DISTINCT availability detail |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | Lead to full routing |
+| (SELECT * FROM tbl_name) | Contain brackets |
+| SELECT MAX(tbl_name.col1) FROM tbl_name | When the select item is a function expression, the real table name cannot be used before the column; if refer a column with table name,please set an alias for the table and use alias to refer a column with the alias |
Review comment:
The select function item contains `TableName`. Otherwise, If this query table had an alias, then `TableAlias` could work well in select function items.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#discussion_r454094107
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
Review comment:
So where is the explanation for this one?
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -110,19 +110,20 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
### 不支持的SQL
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------ | -------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES语句不支持运算表达式 |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | 包含schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 详见DISTINCT支持情况详细说明 |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | 会导致全路由 |
+| (SELECT * FROM tbl_name) | 暂不支持加括号的查询 |
+| SELECT MAX(tbl_name.col1) FROM tbl_name | projection中在函数中需要使用表别名引用查询列 |
Review comment:
1. Many of users maybe have no idea about `projection`, maybe `查询列` will be better
2. There is no `alias` in this statement, so your explanation looks strange and uneasy understanding. My suggestion is to add `IF` condition, for example, `查询列是函数表达式时，查询列前不能使用表名；若查询表存在别名，则可使用表的别名`
##########
File path: docs/document/content/features/sharding/use-norms/sql.en.md
##########
@@ -110,19 +110,20 @@ When shardingColumn in expressions and functions, ShardingSphere will use full r
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
### Unsupported SQL
| SQL | Reason |
| ------------------------------------------------------------------------------------------ | --------------------------------------------------- |
| INSERT INTO tbl_name (col1, col2, ...) VALUES(1+2, ?, ...) | VALUES clause does not support operation expression |
| INSERT INTO tbl_name (col1, col2, ...) SELECT col1, col2, ... FROM tbl_name WHERE col3 = ? | INSERT .. SELECT |
-| SELECT COUNT(col1) as count_alias FROM tbl_name GROUP BY col1 HAVING count_alias > ? | HAVING |
| SELECT * FROM tbl_name1 UNION SELECT * FROM tbl_name2 | UNION |
| SELECT * FROM tbl_name1 UNION ALL SELECT * FROM tbl_name2 | UNION ALL |
-| SELECT * FROM ds.tbl_name1 | Contain schema |
| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | See DISTINCT availability detail |
| SELECT * FROM tbl_name WHERE to_date(create_time, 'yyyy-mm-dd') = ? | Lead to full routing |
+| (SELECT * FROM tbl_name) | Contain brackets |
+| SELECT MAX(tbl_name.col1) FROM tbl_name | Please use table alias to refer to columns in function |
Review comment:
Please change them togather.
##########
File path: docs/document/content/features/sharding/use-norms/sql.cn.md
##########
@@ -149,5 +150,4 @@ SELECT * FROM t_order WHERE to_date(create_time, 'yyyy-mm-dd') = '2019-01-01';
| SQL | 不支持原因 |
| ------------------------------------------------------------------------------------------- |----------------------------------- |
-| SELECT SUM(DISTINCT col1), SUM(col1) FROM tbl_name | 同时使用普通聚合函数和DISTINCT聚合函数 |
-
+| SELECT SUM(DISTINCT tbl_name.col1), SUM(tbl_name.col1) FROM tbl_name | projection中在函数中需要使用表别名来引用查询列 |
Review comment:
Same with the above one.
##########
File path: docs/document/content/features/sharding/use-norms/sql.en.md
##########
@@ -110,19 +110,20 @@ When shardingColumn in expressions and functions, ShardingSphere will use full r
| DROP INDEX idx_name | |
| SELECT DISTINCT * FROM tbl_name WHERE col1 = ? | |
| SELECT COUNT(DISTINCT col1) FROM tbl_name | |
+| SELECT subquery_alias.col1 FROM (select tbl_name.col1 from tbl_name where tbl_name.col2=?) subquery_alias | |
Review comment:
Same with the first one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6293: fix sql support doc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6293:
URL: https://github.com/apache/shardingsphere/pull/6293#issuecomment-655849036
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=h1) Report
> Merging [#6293](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/fa59df0d06238d0488fd00224577ca19f6365ec9&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6293 +/- ##
============================================
- Coverage 52.61% 52.60% -0.01%
Complexity 451 451
============================================
Files 1205 1204 -1
Lines 21494 21498 +4
Branches 3836 3836
============================================
Hits 11308 11308
- Misses 9457 9461 +4
Partials 729 729
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6293/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvd3JhcHBlci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `5.88% <0.00%> (-1.27%)` | `0.00% <0.00%> (ø%)` | |
| [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6293/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvd3JhcHBlci9TdGF0ZW1lbnRFeGVjdXRvcldyYXBwZXIuamF2YQ==) | `5.55% <0.00%> (-1.12%)` | `0.00% <0.00%> (ø%)` | |
| [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/6293/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `18.75% <0.00%> (-0.61%)` | `0.00% <0.00%> (ø%)` | |
| [...ommunication/jdbc/wrapper/JDBCExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/6293/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvd3JhcHBlci9KREJDRXhlY3V0b3JXcmFwcGVyLmphdmE=) | | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=footer). Last update [fa59df0...a38ae3f](https://codecov.io/gh/apache/shardingsphere/pull/6293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org