You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/27 10:48:28 UTC

[GitHub] [airflow] potiuk opened a new pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

potiuk opened a new pull request #15048:
URL: https://github.com/apache/airflow/pull/15048


   With the upcoming apache-beam change where mock library will be
   removed from install dependencies, we will be able to remove
   `apache-beam` exclusion in our CI scripts. This will be a final
   step of cleaning dependencies so that we have a truly
   golden set of constraints that will allow to install airflow
   and all community managed providers (we managed to fix all those
   dependency issues for all packages but apache-beam).
   
   The fix https://github.com/apache/beam/pull/14328 when merged
   and Apache Beam is released will allow us to migrate to the new
   version and get rid of the CI exclusion for beam.
   
   Closes: #14994
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15048:
URL: https://github.com/apache/airflow/pull/15048#issuecomment-808736184


   depends on #15051 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #15048:
URL: https://github.com/apache/airflow/pull/15048


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15048:
URL: https://github.com/apache/airflow/pull/15048#issuecomment-808711644


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15048:
URL: https://github.com/apache/airflow/pull/15048#issuecomment-808718965


   [The Workflow run](https://github.com/apache/airflow/actions/runs/692645544) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #15048: Adds dill exclusion to Dockerfiles to accomodate upcoming beam fix

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15048:
URL: https://github.com/apache/airflow/pull/15048#issuecomment-808710261


   cc: @uranusjr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org