You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/27 14:17:37 UTC

[GitHub] [doris] Yulei-Yang opened a new pull request, #15414: [Improvement](meta) update show create function result

Yulei-Yang opened a new pull request, #15414:
URL: https://github.com/apache/doris/pull/15414

   currently, show create function is designed for native function, it has some non proper point.
   
   this pr bring several improvements, and make result of show create function can be used to create function.
   
   1. add type property.
   2. add ALWAYS_NULLABLE perperty for java_udf
   3. remove md5 property, cos file make vary.
   4. remove INIT_FN,UPDATE_FN,MERGE_FN,SERIALIZE_FN etc properties for java_udf, cos java_udf does not need these properties.
   
   now result:
   | add1(INT)          | CREATE FUNCTION add1(INT) RETURNS INT PROPERTIES (
     "SYMBOL"="org.apache.doris.udf.AddOne",
     "FILE"="file:///data/doris/java-udf-demo-jar-with-dependencies.jar",
     "ALWAYS_NULLABLE"="false",
     "TYPE"="JAVA_UDF"
   );
   
   | sum1(INT)          | CREATE AGGREGATE FUNCTION sum1(INT) RETURNS INT PROPERTIES (
     "SYMBOL"="org.apache.doris.udf.SimpleDemo",
     "FILE"="file:///data/doris/java-udf-demo-jar-with-dependencies.jar",
     "ALWAYS_NULLABLE"="false",
     "TYPE"="JAVA_UDF"
   ); |
   
   
   | add_two(INT, INT)  | CREATE FUNCTION add_two(INT, INT) RETURNS INT PROPERTIES (
     "SYMBOL"="_ZN9doris_udf6AddUdfEPNS_15FunctionContextERKNS_6IntValES4_",
     "OBJECT_FILE"="file:///data/doris/udf/udf_samples/build/src/udf_samples/libudfsample.so",
     "TYPE"="NATIVE"
   ); |
   
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   5. Has unit tests been added:
       - [ ] Yes
       - [x] No
       - [ ] No Need
   6. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   7. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   8. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman merged pull request #15414: [Improvement](meta) update show create function result

Posted by GitBox <gi...@apache.org>.
morningman merged PR #15414:
URL: https://github.com/apache/doris/pull/15414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #15414: [Improvement](meta) update show create function result

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15414:
URL: https://github.com/apache/doris/pull/15414#issuecomment-1366075674

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.06 seconds
    load time: 633 seconds
    storage size: 17123684036 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221227175058_clickbench_pr_69670.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15414: [Improvement](meta) update show create function result

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15414:
URL: https://github.com/apache/doris/pull/15414#issuecomment-1367047534

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #15414: [Improvement](meta) update show create function result

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15414:
URL: https://github.com/apache/doris/pull/15414#issuecomment-1367047541

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org