[jira] [Commented] (CB-11455) Contact plugin crashes on iOS 10

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404873#comment-15404873 ] 

ASF GitHub Bot commented on CB-11455:
-------------------------------------

GitHub user jcesarmobile opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/131

    CB-11455: (ios) Add mandatory iOS 10 privacy description

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds the mandatory `NSContactsUsageDescription` key to the info.plist, allowing to pass the value as a variable.
    Documented the usage of the variable on plugin install as iOS quirk
    
    ### What testing has been done on this change?
    Tested on iOS 10 device
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jcesarmobile/cordova-plugin-contacts CB-11455

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit 0dc9d7b51a5baeac77a9dc30b2edb7cd8c628b18
Author: Julio César <jc...@gmail.com>
Date:   2016-08-02T21:39:16Z

    Added variable to set the usage

----


> Contact plugin crashes on iOS 10
> --------------------------------
>
>                 Key: CB-11455
>                 URL: https://issues.apache.org/jira/browse/CB-11455
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Contacts
>    Affects Versions: 3.5.0
>         Environment: iOS 10
>            Reporter: Eddy Verbruggen
>            Assignee: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided a way to show the user why a certain permission is required. In iOS 10 this becomes mandatory, so any app not specifying the key will crash at runtime when a permissions is requested.
> This plugin requests the Contacts permission, so at the very least we need to add `NSContactsUsageDescription` to the `plist`.
> Note that this is the same approach as the Geolocation plugin has taken a while ago.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org