You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2017/08/29 16:36:02 UTC
[jira] [Closed] (FLINK-7555) Use flink-shaded-guava-18 to replace
guava dependencies
[ https://issues.apache.org/jira/browse/FLINK-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-7555.
-----------------------------------
Resolution: Not A Problem
Certain libraries (cassandra, kinesis, table API) must use vanilla guava since they pull it in through a dependency that exposes gauva in it's API.
We can't replace those.
Libraries other than those 3 are not allowed to import guava which is enforced by checkstyle. Furthermore, we also do not allow unshaded guava dependencies in the flink-dist jar, which is enforced by a check in the travis scripts.
> Use flink-shaded-guava-18 to replace guava dependencies
> --------------------------------------------------------
>
> Key: FLINK-7555
> URL: https://issues.apache.org/jira/browse/FLINK-7555
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Hai Zhou
> Fix For: 1.4.0
>
>
> After [#issue FLINK-6982|https://issues.apache.org/jira/browse/FLINK-6982],
> I still find 40 occurrences of 'import com.google.common' in project .
> we should replace all 'import com.google.common.*' to 'import org.apache.flink.shaded.guava18.com.google.common.*' ?
> if so, I will give a PR to fix it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)