You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by marcuspridham <gi...@git.apache.org> on 2015/05/21 21:31:52 UTC
[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-lib/pull/224
CB-8993 Plugin restore ignores search path
Passes provided searchpath to the plugin restore after adding a platform. Without this I would get errors sometimes about "loadLocalPlugins called twice with different search paths.Support for this is not implemented. "
Also allowing the prepare command to pull the searchpath from the .cordova/config.json if it is present. This aligns with what the platform and plugin commands do.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marcuspridham/cordova-lib CB-8993
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit e03cf3e28414a3e6c375ec4f7275ea1ea67cbf3a
Author: Marcus Pridham <ma...@sap.com>
Date: 2015-05-21T19:10:08Z
CB-8993 Plugin restore ignores search path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...
Posted by gorkem <gi...@git.apache.org>.
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248
@marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to find it if you have. Before I can merge this one, you need to sign Apache’s Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...
Posted by marcuspridham <gi...@git.apache.org>.
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-110080565
Thanks. I filled out a Apache CLA back in January and got confirmation from Apache Secretary Craig Russell. I have done a pull request in the past for CB-8328.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/224#issuecomment-104401689
Good catch. This change looks good to me !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org