You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Blake Bender (JIRA)" <ji...@apache.org> on 2019/05/20 16:09:00 UTC
[jira] [Commented] (GEODE-2371) CI needs to run a target for
checking format on PRs
[ https://issues.apache.org/jira/browse/GEODE-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844077#comment-16844077 ]
Blake Bender commented on GEODE-2371:
-------------------------------------
Gonna go ahead and close this one. The RAT check and Travis build catches this in submitted PRs. We could catch it earlier, but that's a super low-priority task, and realistically we'll never get to it. The important thing is that it is the case that no PR can be merged with incorrect formatting.
> CI needs to run a target for checking format on PRs
> ---------------------------------------------------
>
> Key: GEODE-2371
> URL: https://issues.apache.org/jira/browse/GEODE-2371
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
>
> As a community we will want CI to use the "format" target to automatically check code formatting of PRs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)