You are viewing a plain text version of this content. The canonical link for it is here.

Posted to npanday-dev@incubator.apache.org by Brett Porter <br...@apache.org> on 2010/11/16 06:29:44 UTC

Re: svn commit: r1033832 - in /incubator/npanday/trunk: components/dotnet-artifact/src/main/java/npanday/artifact/impl/ plugins/maven-vsinstaller-plugin/ plugins/maven-vsinstaller-plugin/src/main/java/npanday/plugin/vsinstaller/ plugins/maven-vsinstaller-p...

On 11/11/2010, at 7:05 PM, apadilla@apache.org wrote:

> 
> +            String repo = System.getenv( "PROGRAMFILES" );

How portable is this? It might be better to have a configuration variable for the installation location, and set it to this if not specified?

> +            writer.write( addin.replaceAll( "\\$\\{localRepository\\}", repo.replaceAll( "\\\\", "\\\\\\\\" ) ) );

Should this be a different variable name to be clearer? Is there any built-in technique that could be used to detect the location instead of the substitution?

- Brett

--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/