You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/09 06:24:43 UTC
[GitHub] [dubbo-go] sanxun0325 opened a new pull request #784: [#774] fix metadata default port
sanxun0325 opened a new pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
https://github.com/apache/dubbo-go/issues/774
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
- Coverage 59.80% 59.78% -0.03%
===========================================
Files 259 259
Lines 12737 12745 +8
===========================================
+ Hits 7617 7619 +2
- Misses 4166 4169 +3
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `81.57% <44.44%> (-11.97%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.41% <50.00%> (-0.04%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...389c351](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
- Coverage 59.80% 59.78% -0.03%
===========================================
Files 259 259
Lines 12737 12745 +8
===========================================
+ Hits 7617 7619 +2
- Misses 4166 4169 +3
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `81.57% <44.44%> (-11.97%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.41% <50.00%> (-0.04%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...fa5e474](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
- Coverage 59.80% 59.78% -0.03%
===========================================
Files 259 259
Lines 12737 12745 +8
===========================================
+ Hits 7617 7619 +2
- Misses 4166 4169 +3
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `81.57% <44.44%> (-11.97%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.41% <50.00%> (-0.04%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...e4a25ed](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
- Coverage 59.80% 59.78% -0.03%
===========================================
Files 259 259
Lines 12737 12745 +8
===========================================
+ Hits 7617 7619 +2
- Misses 4166 4169 +3
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `81.57% <44.44%> (-11.97%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.41% <50.00%> (-0.04%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...e4a25ed](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sanxun0325 commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
sanxun0325 commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r508919324
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +47,18 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
+ if url == nil || url.SubURL == nil {
+ return errors.New("the url or url.SubURL cannot be nil")
+ }
Review comment:
@zouyx updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
+ Coverage 59.80% 59.92% +0.12%
===========================================
Files 259 259
Lines 12737 12752 +15
===========================================
+ Hits 7617 7642 +25
+ Misses 4166 4153 -13
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.44% <50.00%> (ø)` | |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `93.75% <100.00%> (+0.20%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...65f5a10](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r508202951
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +47,18 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
+ if url == nil || url.SubURL == nil {
+ return errors.New("the url or url.SubURL cannot be nil")
+ }
Review comment:
Pls modify the error description. Such as 'Metadata Server url is nil, pls check your configuration'. It should be friendly infomation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
+ Coverage 59.80% 59.92% +0.11%
===========================================
Files 259 259
Lines 12737 12757 +20
===========================================
+ Hits 7617 7644 +27
+ Misses 4166 4156 -10
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.44% <50.00%> (ø)` | |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.59% <100.00%> (+1.04%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.60% <0.00%> (-3.27%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...a2898c9](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r507665508
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +46,21 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
- serviceConfig.Protocols = map[string]*config.ProtocolConfig{
- constant.DEFAULT_PROTOCOL: generateMetadataProtocol(),
+ if url != nil && url.SubURL != nil {
+ serviceConfig.Protocols = map[string]*config.ProtocolConfig{
+ constant.DEFAULT_PROTOCOL: {
+ Name: url.SubURL.Protocol,
+ Port: url.SubURL.Port,
+ },
+ }
+ } else {
Review comment:
Yes
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +46,21 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
- serviceConfig.Protocols = map[string]*config.ProtocolConfig{
- constant.DEFAULT_PROTOCOL: generateMetadataProtocol(),
+ if url != nil && url.SubURL != nil {
+ serviceConfig.Protocols = map[string]*config.ProtocolConfig{
+ constant.DEFAULT_PROTOCOL: {
+ Name: url.SubURL.Protocol,
+ Port: url.SubURL.Port,
+ },
+ }
+ } else {
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sanxun0325 commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
sanxun0325 commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r507303096
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +46,21 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
- serviceConfig.Protocols = map[string]*config.ProtocolConfig{
- constant.DEFAULT_PROTOCOL: generateMetadataProtocol(),
+ if url != nil && url.SubURL != nil {
+ serviceConfig.Protocols = map[string]*config.ProtocolConfig{
+ constant.DEFAULT_PROTOCOL: {
+ Name: url.SubURL.Protocol,
+ Port: url.SubURL.Port,
+ },
+ }
+ } else {
Review comment:
When the URL is nil, it returns an error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
+ Coverage 59.80% 59.92% +0.11%
===========================================
Files 259 259
Lines 12737 12757 +20
===========================================
+ Hits 7617 7644 +27
+ Misses 4166 4156 -10
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.44% <50.00%> (ø)` | |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.59% <100.00%> (+1.04%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.60% <0.00%> (-3.27%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...f7f3cf2](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r507164250
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +46,21 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
- serviceConfig.Protocols = map[string]*config.ProtocolConfig{
- constant.DEFAULT_PROTOCOL: generateMetadataProtocol(),
+ if url != nil && url.SubURL != nil {
+ serviceConfig.Protocols = map[string]*config.ProtocolConfig{
+ constant.DEFAULT_PROTOCOL: {
+ Name: url.SubURL.Protocol,
+ Port: url.SubURL.Port,
+ },
+ }
+ } else {
Review comment:
this else is not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r508243122
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -46,12 +47,18 @@ func NewMetadataServiceExporter(metadataService service.MetadataService) exporte
}
// Export will export the metadataService
-func (exporter *MetadataServiceExporter) Export() error {
+func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
if !exporter.IsExported() {
serviceConfig := config.NewServiceConfig(constant.SIMPLE_METADATA_SERVICE_NAME, context.Background())
serviceConfig.Protocol = constant.DEFAULT_PROTOCOL
+ if url == nil || url.SubURL == nil {
+ return errors.New("the url or url.SubURL cannot be nil")
+ }
Review comment:
@sanxun0325 fix or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#discussion_r507082549
##########
File path: metadata/service/exporter/configurable/exporter_test.go
##########
@@ -18,6 +18,7 @@
package configurable
import (
+ "github.com/apache/dubbo-go/common"
Review comment:
move it to the third import block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt merged pull request #784: Fix: issue 774 [fix metadata default port]
Posted by GitBox <gi...@apache.org>.
hxmhlt merged pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #784: [#774] fix metadata default port
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #784:
URL: https://github.com/apache/dubbo-go/pull/784#issuecomment-706116637
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=h1) Report
> Merging [#784](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #784 +/- ##
===========================================
+ Coverage 59.80% 59.92% +0.11%
===========================================
Files 259 259
Lines 12737 12757 +20
===========================================
+ Hits 7617 7644 +27
+ Misses 4166 4156 -10
- Partials 954 957 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.44% <50.00%> (ø)` | |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.59% <100.00%> (+1.04%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `57.60% <0.00%> (-3.27%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/784/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=footer). Last update [c6c0535...389c351](https://codecov.io/gh/apache/dubbo-go/pull/784?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org