[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #7534: Fix flaky test_sort_fetch_memory_calculation

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #7534:
URL: https://github.com/apache/arrow-datafusion/pull/7534#discussion_r1323607155


##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -1097,7 +1097,7 @@ mod tests {
                 .with_fetch(fetch),
             );
 
-            let result = collect(sort_exec.clone(), task_ctx).await?;
+            let result = collect(sort_exec.clone(), task_ctx.clone()).await?;

Review Comment:
   `task_ctx` is simply moved `task_ctx`. Before the stream future is resolved, it is dropped early.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org