You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/19 18:52:58 UTC
Review Request: SQOOP-710 Remove dependency on unreleased commons-cli 1.3
from Sqoop 2 client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8125/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've changed dependency from 1.3-SNAPSHOT to 1.2 and fixed compilation issues (missing class DefaultParser).
This addresses bug SQOOP-710.
https://issues.apache.org/jira/browse/SQOOP-710
Diffs
-----
client/pom.xml 235dcea0f52b6cfd7c9c6edbd8a71b3861f004f0
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java af0579d43427e59d32f75b6a7f16d5dec8b38750
Diff: https://reviews.apache.org/r/8125/diff/
Testing
-------
Unit tests are passing and I also tested my change on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-710 Remove dependency on unreleased commons-cli
1.3 from Sqoop 2 client
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8125/#review13579
-----------------------------------------------------------
Ship it!
One main reason to use 1.3 is to avoid CLI-185 (http://issues.apache.org/jira/browse/CLI-185). It would be better to also document this issue if it is decided to fall back to 1.2.
- Bilung Lee
On Nov. 19, 2012, 5:52 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8125/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 5:52 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed dependency from 1.3-SNAPSHOT to 1.2 and fixed compilation issues (missing class DefaultParser).
>
>
> This addresses bug SQOOP-710.
> https://issues.apache.org/jira/browse/SQOOP-710
>
>
> Diffs
> -----
>
> client/pom.xml 235dcea0f52b6cfd7c9c6edbd8a71b3861f004f0
> client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java af0579d43427e59d32f75b6a7f16d5dec8b38750
>
> Diff: https://reviews.apache.org/r/8125/diff/
>
>
> Testing
> -------
>
> Unit tests are passing and I also tested my change on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>