[GitHub] frankfliu commented on issue #13626: Re-organize Scala maven build

[GitBox <gi...@apache.org>]

frankfliu commented on issue #13626: Re-organize Scala maven build
URL: https://github.com/apache/incubator-mxnet/pull/13626#issuecomment-447405913
 
 
   ${scala.binary.version} is a mistake in original maven.
   ${scala.binary.version}  was used in artifact id, not for scale compiler target version.
   1. We already release 2.11 artifact on maven central, we can't simple change it, 2.12 will be different package on maven central.
   2. in pom, artifact id in pom.xml should be a constants, not a variable
   3. I removed all internal reference to ${scala.binary.version}, and only kept in public facing artifact name.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services