You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "funky-eyes (via GitHub)" <gi...@apache.org> on 2024/04/18 02:04:42 UTC
[PR] [WIP]test: optimize FileConfigurationTest [incubator-seata]
funky-eyes opened a new pull request, #6484:
URL: https://github.com/apache/incubator-seata/pull/6484
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix FileConfigurationTest and MockServerTest fail [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6484:
URL: https://github.com/apache/incubator-seata/pull/6484#discussion_r1574266990
##########
test/src/test/java/org/apache/seata/core/rpc/netty/mockserver/MockServerTest.java:
##########
@@ -37,16 +41,22 @@ public class MockServerTest {
static String RESOURCE_ID = "mock-action";
+ Logger logger = LoggerFactory.getLogger(MockServerTest.class);
+
@BeforeAll
Review Comment:
考虑后续再做修改，暂时先尽最大能力节约ci的耗时
Consider subsequent modifications, and do your best to save the time-consuming ci for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix FileConfigurationTest and MockServerTest fail [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6484:
URL: https://github.com/apache/incubator-seata/pull/6484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix FileConfigurationTest and MockServerTest fail [incubator-seata]
Posted by "Bughue (via GitHub)" <gi...@apache.org>.
Bughue commented on code in PR #6484:
URL: https://github.com/apache/incubator-seata/pull/6484#discussion_r1574254646
##########
test/src/test/java/org/apache/seata/core/rpc/netty/mockserver/MockServerTest.java:
##########
@@ -37,16 +41,22 @@ public class MockServerTest {
static String RESOURCE_ID = "mock-action";
+ Logger logger = LoggerFactory.getLogger(MockServerTest.class);
+
@BeforeAll
Review Comment:
之前一直在考虑有没有必要在这里用@ BeforeEach ，不然在单个@Test方法里这个不会重新执行，这次可以再考虑下要不要改
I've been wondering if it's necessary to use @ BeforeEach here, otherwise this won't be re-executed in a single @Test method, so I'll reconsider this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix FileConfigurationTest and MockServerTest fail [incubator-seata]
Posted by "Bughue (via GitHub)" <gi...@apache.org>.
Bughue commented on PR #6484:
URL: https://github.com/apache/incubator-seata/pull/6484#issuecomment-2068680598
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix FileConfigurationTest and MockServerTest fail [incubator-seata]
Posted by "Bughue (via GitHub)" <gi...@apache.org>.
Bughue commented on code in PR #6484:
URL: https://github.com/apache/incubator-seata/pull/6484#discussion_r1574254646
##########
test/src/test/java/org/apache/seata/core/rpc/netty/mockserver/MockServerTest.java:
##########
@@ -37,16 +41,22 @@ public class MockServerTest {
static String RESOURCE_ID = "mock-action";
+ Logger logger = LoggerFactory.getLogger(MockServerTest.class);
+
@BeforeAll
Review Comment:
之前一直在考虑有没有必要在这里用@BeforeEach ，不然在单个@test方法里这个不会重新执行，这次可以再考虑下要不要改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org