You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "gesterzhou (GitHub)" <gi...@apache.org> on 2020/03/30 07:08:18 UTC

[GitHub] [geode] gesterzhou opened pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

        Co-authored-by: Anil <ag...@pivotal.io>
        Co-authored-by: Xiaojian Zhou <gz...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "agingade (GitHub)" <gi...@apache.org>.

The test is doing region destroy but the name suggests it is for clear. All the tests are doing region destroy, rather than clear.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "gesterzhou (GitHub)" <gi...@apache.org>.

It's kind of "TODO". 

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "agingade (GitHub)" <gi...@apache.org>.

Can the caller pass in the Processor. We could avoid checking for operation.
Also is paction -> processorAction ? can we make it clear. Sorry for nitpicking. Just wanted to be clear with what we are doing.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] DonalEvans commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "DonalEvans (GitHub)" <gi...@apache.org>.

It seems inefficient and confusing to set the cache writer for all three data stores, then to immediately remove the writers for datastores1 and 2. Could you instead just pass `false` as the second argument for `initDataStore()` for those datastores?

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] DonalEvans commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "DonalEvans (GitHub)" <gi...@apache.org>.

Remove commented code.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "agingade (GitHub)" <gi...@apache.org>.

I agree with Donal, doing this we are testing the behavior of AttributesMutator, not for clear. 

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] DonalEvans commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "DonalEvans (GitHub)" <gi...@apache.org>.

Remove commented code.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "agingade (GitHub)" <gi...@apache.org>.

There is "PartitionedRegionLoaderWriterDUnitTest" specific to testing loader and writers on PR. Probably we should move these tests over there.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "agingade (GitHub)" <gi...@apache.org>.

Does this PR requires CacheListener testing.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] DonalEvans commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "DonalEvans (GitHub)" <gi...@apache.org>.

Is there something missing here, or can this comment be removed?

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] DonalEvans commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "DonalEvans (GitHub)" <gi...@apache.org>.

Remove commented code.

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #4882: GEODE-7912: cacheWriter should be triggered when PR.clear

Posted by "gesterzhou (GitHub)" <gi...@apache.org>.

I read the PartitionedRegionLoaderWriterDUnitTest. That is only to verify compatibility when creating region. We are testing the clear() operation's behavior. 

[ Full content available at: https://github.com/apache/geode/pull/4882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org