You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "mattrpav (via GitHub)" <gi...@apache.org> on 2024/04/23 16:44:15 UTC
[PR] [AMQ-9484] Support exporting kahadb messages from a queue with an offset [activemq]
mattrpav opened a new pull request, #1207:
URL: https://github.com/apache/activemq/pull/1207
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [AMQ-9484] Support exporting kahadb messages from a queue with an offset - Option B [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2142861478
Closing in favor of https://github.com/apache/activemq/pull/1208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] WIP: [AMQ-9484] Support exporting kahadb messages from a queue with an offset - Option B [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav closed pull request #1207: WIP: [AMQ-9484] Support exporting kahadb messages from a queue with an offset - Option B
URL: https://github.com/apache/activemq/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9484] Support exporting kahadb messages from a queue with an offset [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2073055053
One reason I thought iterating over the index was preferred vs seeking over the index was to skip over and not include any messages in the ackedAndPrepared collection.
```
if (ackedAndPrepared != null && ackedAndPrepared.contains(entry.getValue().messageId)) {
continue;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: [AMQ-9484] Support exporting kahadb messages from a queue with an offset - Option B [activemq]
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2142861143
Closing in favor of https://github.com/apache/activemq/pull/1208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] [AMQ-9484] Support exporting kahadb messages from a queue with an offset [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1207:
URL: https://github.com/apache/activemq/pull/1207#issuecomment-2073017418
I only took a quick glance but 2 things stand out to me immediately that are issues:
1. The current PR is using recoverNextMessages() which changes state of the cursor, so this definitely won't work in an online broker without breaking the queue if the intent is for a user to use this to export while a broker is online.
2. This scans through the index and just skips when you could just use MessageOrderIndex with the order iterator and skip ahead by setting the batch location on the index
This needs a bit more context with use cases to see how this is intended to be used to probably know the best way of doing some of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org