[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8930: add 'prefixes' support to google input source

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #8930: add 'prefixes' support to google input source
URL: https://github.com/apache/incubator-druid/pull/8930#discussion_r353962461
 
 

 ##########
 File path: extensions-core/google-extensions/src/main/java/org/apache/druid/data/input/google/GoogleCloudStorageEntity.java
 ##########
 @@ -33,36 +34,31 @@
 
 public class GoogleCloudStorageEntity extends RetryingInputEntity
 {
-  private final GoogleStorage storage;
-  private final URI uri;
+  private final GoogleByteSource byteSource;
 
-  GoogleCloudStorageEntity(GoogleStorage storage, URI uri)
+  GoogleCloudStorageEntity(GoogleStorage storage, CloudObjectLocation location)
   {
-    this.storage = storage;
-    this.uri = uri;
+    this.byteSource = new GoogleByteSource(storage, location.getBucket(), location.getPath());
   }
 
   @Nullable
   @Override
   public URI getUri()
   {
-    return uri;
+    return null;
 
 Review comment:
   Doesn't look like the method is called in the codebase currently but this could construct a URI from the bucket/path if needed. 
   
   `S3Entity` currently returns null for this as well, could probably have a comment on why in both locations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org