You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tssahota (via GitHub)" <gi...@apache.org> on 2024/12/18 10:52:10 UTC
[PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
tssahota opened a new pull request, #45025:
URL: https://github.com/apache/airflow/pull/45025
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #28830 https://github.com/apache/airflow/issues/28830
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
Enable DynamoDbToS3Operator to return point in time export ARN to x_com. The ARN may be required by downstream tasks to get export location in s3.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1915407494
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -225,6 +226,7 @@ def _export_entire_data(self):
finally:
if err is None:
_upload_file_to_s3(f, self.s3_bucket_name, self.s3_key_prefix, self.dest_aws_conn_id)
+ return None
Review Comment:
Not sure this is needed
##########
providers/tests/amazon/aws/transfers/test_dynamodb_to_s3.py:
##########
@@ -324,8 +324,9 @@ def test_dynamodb_execute_calling_export_table_to_point_in_time(self, _export_ta
point_in_time_export=True,
export_time=datetime(year=1983, month=1, day=1),
)
- dynamodb_to_s3_operator.execute(context={})
+ export_arn = dynamodb_to_s3_operator.execute(context={})
_export_table_to_point_in_time.assert_called()
+ assert export_arn is not None
Review Comment:
Could you mock the exported arn using `_export_table_to_point_in_time` and expect that the returned value is the value you set in the mock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "tssahota (via GitHub)" <gi...@apache.org>.
tssahota commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1905266412
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -166,15 +166,14 @@ def execute(self, context: Context) -> None:
# function. This change introduces a new boolean, as the indicator for whether the operator scans
# and export entire data or using the point in time functionality.
if self.point_in_time_export or self.export_time:
- self._export_table_to_point_in_time()
- else:
- self._export_entire_data()
+ return self._export_table_to_point_in_time()
+ return self._export_entire_data()
Review Comment:
Hi @eladkal, sorry for the delay, first time contributor, I assume you mean to remove the else and return the _export_entire_data() function when if condition is False.
Please let me know if there's a better alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #45025: Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator
URL: https://github.com/apache/airflow/pull/45025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1891575056
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -166,15 +167,15 @@ def execute(self, context: Context) -> None:
# function. This change introduces a new boolean, as the indicator for whether the operator scans
# and export entire data or using the point in time functionality.
if self.point_in_time_export or self.export_time:
- self._export_table_to_point_in_time()
+ return self._export_table_to_point_in_time()
else:
- self._export_entire_data()
+ return self._export_entire_data()
Review Comment:
if adding return statement then there is no need for `else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1890662691
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -101,6 +101,7 @@ class DynamoDBToS3Operator(AwsToAwsBaseOperator):
:param check_interval: The amount of time in seconds to wait between attempts. Only if ``export_time`` is
provided.
:param max_attempts: The maximum number of attempts to be made. Only if ``export_time`` is provided.
+ "returns export_arn: Export ARN value in case of 'point in time export' or None for 'scan'
Review Comment:
You do not need this parameter. You do not use it either
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "tssahota (via GitHub)" <gi...@apache.org>.
tssahota commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1905266412
##########
providers/src/airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -166,15 +166,14 @@ def execute(self, context: Context) -> None:
# function. This change introduces a new boolean, as the indicator for whether the operator scans
# and export entire data or using the point in time functionality.
if self.point_in_time_export or self.export_time:
- self._export_table_to_point_in_time()
- else:
- self._export_entire_data()
+ return self._export_table_to_point_in_time()
+ return self._export_entire_data()
Review Comment:
Hi @eladkal, sorry for the delay, first time contributer, I assume you mean to remove the else and return the _export_entire_data() function when if condition is False.
Please let me know if there's a better alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #45025:
URL: https://github.com/apache/airflow/pull/45025#issuecomment-2551001484
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45025:
URL: https://github.com/apache/airflow/pull/45025#issuecomment-2691757955
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "tssahota (via GitHub)" <gi...@apache.org>.
tssahota commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1905270281
##########
providers/tests/amazon/aws/transfers/test_dynamodb_to_s3.py:
##########
@@ -324,8 +324,9 @@ def test_dynamodb_execute_calling_export_table_to_point_in_time(self, _export_ta
point_in_time_export=True,
export_time=datetime(year=1983, month=1, day=1),
)
- dynamodb_to_s3_operator.execute(context={})
+ export_arn = dynamodb_to_s3_operator.execute(context={})
_export_table_to_point_in_time.assert_called()
+ assert export_arn is not None
Review Comment:
Hi , I have updated an existing test case to check for a non-null export_arn. Will this suffice with regard to this [comment](https://github.com/apache/airflow/pull/45025#pullrequestreview-2512558474).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding functionality to return export ARN for point in time export in DynamoDBToS3Operator [airflow]
Posted by "tssahota (via GitHub)" <gi...@apache.org>.
tssahota commented on code in PR #45025:
URL: https://github.com/apache/airflow/pull/45025#discussion_r1905270281
##########
providers/tests/amazon/aws/transfers/test_dynamodb_to_s3.py:
##########
@@ -324,8 +324,9 @@ def test_dynamodb_execute_calling_export_table_to_point_in_time(self, _export_ta
point_in_time_export=True,
export_time=datetime(year=1983, month=1, day=1),
)
- dynamodb_to_s3_operator.execute(context={})
+ export_arn = dynamodb_to_s3_operator.execute(context={})
_export_table_to_point_in_time.assert_called()
+ assert export_arn is not None
Review Comment:
Hi @vincbeck, I have updated an existing test case to check for a non-null export_arn. Will this suffice with regard to this [comment](https://github.com/apache/airflow/pull/45025#pullrequestreview-2512558474)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org