You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2015/04/16 10:15:30 UTC

[Bug 7175] New: uri_detail rule breaks "make test"

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

            Bug ID: 7175
           Summary: uri_detail rule breaks "make test"
           Product: Spamassassin
           Version: 3.4 SVN branch
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: blocker
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: axb.lists@gmail.com

this rule seems to breaks "make test"

uri_detail      AXB_URIDETAIL_TEST    text =~ /test/

lint: config: failed to parse line, skipping, in "rules/72_active.cf":
uri_detail      AXB_URIDETAIL_TEST       text =~ /test/ at build/mkrules line
255.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Kevin A. McGrail <km...@pccc.com> ---
Plugin Encapsulation on the rule resolved the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

--- Comment #7 from AXB <ax...@gmail.com> ---
(In reply to Kevin A. McGrail from comment #6)
> (In reply to AXB from comment #5)
> > could we make sure that these (non network test) plugins are all enabled for
> > jenkins?
> 
> Administering the perl on jenkins and various modules is hell.  
> 
> And to me, this showed an issue where you forgot to encapsulate which could
> be an issue for anyone with URIDetail disabled.

ok....

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

--- Comment #3 from Kevin A. McGrail <km...@pccc.com> ---
And coupled with the lack of plugin encapsulation, things could be problematic
is my guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

--- Comment #6 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to AXB from comment #5)
> could we make sure that these (non network test) plugins are all enabled for
> jenkins?

Administering the perl on jenkins and various modules is hell.  

And to me, this showed an issue where you forgot to encapsulate which could be
an issue for anyone with URIDetail disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
My guess is ifplugin Mail::SpamAssassin::Plugin::URIDetail is needed:

svn commit -m 'Working on Jenkins issue - Believe it might be a plugin
requirement'
Sending        axb/20_axb_misc.cf
Transmitting file data .
Committed revision 1674036.

&

svn commit -m 'Might as well test the real rule'
Sending        axb/20_axb_misc.cf
Transmitting file data .
Committed revision 1674037.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

--- Comment #5 from AXB <ax...@gmail.com> ---
could we make sure that these (non network test) plugins are all enabled for
jenkins?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7175] uri_detail rule breaks "make test"

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7175

--- Comment #2 from Mark Martinec <Ma...@ijs.si> ---
build/mkrules is not loading Mail::SpamAssassin::Plugin::URIDetail :


sub lint_rule_text {
  my ($text) = @_;

  # ensure we turn off slow/optional stuff for linting, but keep the essentials
  my $pretext = q{
    loadplugin Mail::SpamAssassin::Plugin::Check
    loadplugin Mail::SpamAssassin::Plugin::URIDNSBL
    use_bayes 0
  };

-- 
You are receiving this mail because:
You are the assignee for the bug.