You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/07 10:05:56 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
tillrohrmann opened a new pull request #14577:
URL: https://github.com/apache/flink/pull/14577
## What is the purpose of the change
In order to easily connect to an HA enabled Yarn cluster, this commit sets the
high-availability.cluster-id to the application id if not configured. This is
symmetric to how we deploy HA enabled clusters and makes it unnecessary to
explicitly set the high-availability.cluster-id if one tries to reconnect
to the cluster.
## Verifying this change
Added `YARNHighAvailabilityITCase.testClusterClientRetrieval`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756065790
Thanks for the review @zentol. I've addressed your comments and updated this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf70e96ab2231aabf6e6af3801d314510bfc157 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553277240
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport report) {
flinkConfiguration.set(
YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+ // set cluster-id to app id if not specified
+ if (!flinkConfiguration.contains(HighAvailabilityOptions.HA_CLUSTER_ID)) {
Review comment:
Ok, I've removed `YarnClusterDescriptor.zookeeperNamespace` as it seems to be no longer used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756018686
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bdf70e96ab2231aabf6e6af3801d314510bfc157 (Thu Jan 07 10:08:04 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
}, {
"hash" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745",
"triggerID" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 615f3b2a84fb56c696287dd8c1afcff014451d2e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553235608
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport report) {
flinkConfiguration.set(
YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+ // set cluster-id to app id if not specified
+ if (!flinkConfiguration.contains(HighAvailabilityOptions.HA_CLUSTER_ID)) {
Review comment:
Should we deduplicate/sync this block with the one in `#startAppMaster`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553273001
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport report) {
flinkConfiguration.set(
YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+ // set cluster-id to app id if not specified
+ if (!flinkConfiguration.contains(HighAvailabilityOptions.HA_CLUSTER_ID)) {
Review comment:
Ok, let me see what I can simplify here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14577:
URL: https://github.com/apache/flink/pull/14577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
}, {
"hash" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745",
"triggerID" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf70e96ab2231aabf6e6af3801d314510bfc157 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736)
* 615f3b2a84fb56c696287dd8c1afcff014451d2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553273340
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport report) {
flinkConfiguration.set(
YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+ // set cluster-id to app id if not specified
Review comment:
Jup, good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14577:
URL: https://github.com/apache/flink/pull/14577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756018686
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 615f3b2a84fb56c696287dd8c1afcff014451d2e (Fri May 28 07:03:11 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14577:
URL: https://github.com/apache/flink/pull/14577#discussion_r553236321
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1781,6 +1781,12 @@ private void setClusterEntrypointInfoToConfig(final ApplicationReport report) {
flinkConfiguration.set(
YarnConfigOptions.APPLICATION_ID, ConverterUtils.toString(clusterId));
+
+ // set cluster-id to app id if not specified
Review comment:
maybe rename the `clusterId` variable to `appId`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf70e96ab2231aabf6e6af3801d314510bfc157 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
}, {
"hash" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf70e96ab2231aabf6e6af3801d314510bfc157 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736)
* 615f3b2a84fb56c696287dd8c1afcff014451d2e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14577: [FLINK-20866][yarn] Set high-availability.cluster-id to application id if not configured
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14577:
URL: https://github.com/apache/flink/pull/14577#issuecomment-756025497
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736",
"triggerID" : "bdf70e96ab2231aabf6e6af3801d314510bfc157",
"triggerType" : "PUSH"
}, {
"hash" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745",
"triggerID" : "615f3b2a84fb56c696287dd8c1afcff014451d2e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bdf70e96ab2231aabf6e6af3801d314510bfc157 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11736)
* 615f3b2a84fb56c696287dd8c1afcff014451d2e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11745)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org