[GitHub] [incubator-openwhisk] selfxp commented on a change in pull request #4407: Use static metric names when tag support is enabled

[GitBox <gi...@apache.org>]

selfxp commented on a change in pull request #4407: Use static metric names when tag support is enabled
URL: https://github.com/apache/incubator-openwhisk/pull/4407#discussion_r269920392
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala
 ##########
 @@ -376,18 +379,38 @@ object LoggingMarkers {
   /*
    * Invoker related markers
    */
-  def INVOKER_STARTUP(i: Int) = LogMarkerToken(invoker, s"startup$i", counter)(MeasurementUnit.none)
+  def INVOKER_STARTUP(i: Int) =
+    if (TransactionId.metricsKamonTags)
+      LogMarkerToken(invoker, s"startup", counter, None, Map("invoker_id" -> i.toString))(MeasurementUnit.none)
 
 Review comment:
   👍 This would allow grouping by `invoker` in Datadog

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services