[jira] [Commented] (NET-591) FTPTimeStampParserImpl failing when parsing correctly formed datetimestring (daylight saving issue)

["Dan Lipofsky (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396444#comment-16396444 ] 

Dan Lipofsky commented on NET-591:
----------------------------------

I just encountered the same problem because of daylight savings time.

[~sebb@apache.org] you say "assuming that the correct server timezone has been specified" but what if you don't know the server timezone? In my case I do not run the server and I am not sure of its timezone.

> FTPTimeStampParserImpl failing when parsing correctly formed datetimestring (daylight saving issue)
> ---------------------------------------------------------------------------------------------------
>
>                 Key: NET-591
>                 URL: https://issues.apache.org/jira/browse/NET-591
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.4
>         Environment: locale: sv_SE
> timezone: "Europe/Stockholm"
> llinux/unix
>            Reporter: J
>
> In the class FTPTimeStampParserImpl,
> the SimpleDateFormat hackFormatter
> will throw an exception for certain datestrings, even though their SimpleDateFormat pattern for the hackFormatter instance is correct ("MMM d HH:mm yyyy")
> when in an environment that has daylight savings, like the environment reported in this bug report.
> For example:
> Line 123:          
>  parsed = hackFormatter.parse(timeStampStrPlusYear, pp);
> where timeStampStrPlusyear = "Mar 27 02:02 2016"
> will fail but 
>  timeStampStrPlusyear = "Mar 27 03:02 2016"
> would work.
> The problem is according to http://blog.tier1app.com/2013/05/29/daylight-savings-time-problem-java/ that because of the daylight saving, the time 
> 02:02 doesn't exist in my timezone (thats true - timezone leap was 02:00 the 27th).
> Setting the hackformatters lenient to true would make it work, or maybe check if the given date with the default created timezone was in daylight saving.
> However I don't know if that's the right way for this project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)