You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/03 13:55:06 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #16523: [FLINK-23416][runtime] Don't log NoResourceAvailableException stacktrace
tillrohrmann commented on a change in pull request #16523:
URL: https://github.com/apache/flink/pull/16523#discussion_r681782400
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1435,8 +1437,18 @@ private boolean transitionState(
getAttemptId(),
currentState,
targetState);
- } else {
- if (LOG.isInfoEnabled()) {
+ } else if (LOG.isInfoEnabled()) {
+ Optional<NoResourceAvailableException> noResourceException =
+ findThrowable(error, NoResourceAvailableException.class);
+ if (noResourceException.isPresent()) {
+ LOG.info(
+ "{} ({}) switched from {} to {}",
+ getVertex().getTaskNameWithSubtaskIndex(),
+ getAttemptId(),
+ currentState,
+ targetState,
+ noResourceException.get());
+ } else {
Review comment:
For that we could use `ExceptionUtils.stripCompletionException(error)` because `CompletionExceptions` are rarely helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org