You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/21 16:56:59 UTC
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #26556: Fix grid view log try numbers
pierrejeambrun commented on code in PR #26556:
URL: https://github.com/apache/airflow/pull/26556#discussion_r976778067
##########
airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx:
##########
@@ -99,12 +98,13 @@ const Logs = ({
tryNumber,
}: Props) => {
const [internalIndexes, externalIndexes] = getLinkIndexes(tryNumber);
- const [selectedAttempt, setSelectedAttempt] = useState(1);
+ const [manuallySelectedAttempt, setSelectedAttempt] = useState<number | undefined>();
Review Comment:
Not: Should we rename also the setter ? (Not a big fan of having the state and its setter with different names)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org