You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/17 10:23:28 UTC
[GitHub] [echarts] Map1en opened a new pull request #14968: fix(radar): display of empty symbol is not normal
Map1en opened a new pull request #14968:
URL: https://github.com/apache/echarts/pull/14968
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix(radar): display of empty symbol is not normal
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
### Fixed issues
close #14819
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
lineWidth is too large and the empty symbol is not displayed properly.
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
set lineWidth = 0.5
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#discussion_r633424993
##########
File path: src/chart/radar/RadarView.ts
##########
@@ -241,6 +241,8 @@ class RadarView extends ChartView {
else {
symbolPath.useStyle(itemStyle);
symbolPath.setColor(color);
+ // fix display of empty symbol is not normal
+ symbolPath.__isEmptyBrush && (symbolPath.style.lineWidth = 0.5);
Review comment:
I don't think it's good to fix the width of the border. Especially to a very thin value that may have display issues on the 1x DPR monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#discussion_r633424993
##########
File path: src/chart/radar/RadarView.ts
##########
@@ -241,6 +241,8 @@ class RadarView extends ChartView {
else {
symbolPath.useStyle(itemStyle);
symbolPath.setColor(color);
+ // fix display of empty symbol is not normal
+ symbolPath.__isEmptyBrush && (symbolPath.style.lineWidth = 0.5);
Review comment:
I don't think it's good to fix the width of the border. Especially to a very thin value that may have display issues on the 1x DPR monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#issuecomment-842207792
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#issuecomment-939208032
It is fixed in https://github.com/apache/echarts/pull/15396/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#issuecomment-842207792
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang closed pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
pissang closed pull request #14968:
URL: https://github.com/apache/echarts/pull/14968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on pull request #14968: fix(radar): display of empty symbol is not normal
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #14968:
URL: https://github.com/apache/echarts/pull/14968#issuecomment-939208032
Seems it's the same issue with https://github.com/apache/echarts/pull/15396/files and has been fixed since 5.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org