You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/30 09:17:19 UTC
[GitHub] [zookeeper] symat commented on a change in pull request #1835: ZOOKEEPER-4490 - Publish Clover results to SonarQube
symat commented on a change in pull request #1835:
URL: https://github.com/apache/zookeeper/pull/1835#discussion_r838298080
##########
File path: pom.xml
##########
@@ -445,6 +445,97 @@
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
+ <profile>
+ <id>clover</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <property>
+ <name>clover</name>
+ </property>
+ </activation>
+ <properties>
+ <cloverDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverDatabase>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.openclover</groupId>
+ <artifactId>clover-maven-plugin</artifactId>
+ <configuration>
+ <includesAllSourceRoots>false</includesAllSourceRoots>
+ <includesTestSourceRoots>true</includesTestSourceRoots>
+ <cloverDatabase>${cloverDatabase}</cloverDatabase>
+ <targetPercentage>50%</targetPercentage>
+ <outputDirectory>${project.build.directory}/clover</outputDirectory>
+ <alwaysReport>true</alwaysReport>
+ <generateHistorical>false</generateHistorical>
+ <cloverDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverDatabase>
+ <cloverMergeDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverMergeDatabase>
+ <outputDirectory>${project.build.directory}/clover</outputDirectory>
+ <generateHtml>true</generateHtml>
+ <generateXml>true</generateXml>
+ <includesAllSourceRoots>false</includesAllSourceRoots>
+ <includesTestSourceRoots>true</includesTestSourceRoots>
+ <includes>
+ <include>org/apache/zookeeper/**/*</include>
+ </includes>
+ <excludes>
+ <exclude>org/apache/zookeeper/version/**/*</exclude>
+ <exclude>**/ReadOnlyModeTest.java</exclude>
+ <exclude>**/KeeperStateTest.java</exclude>
+ </excludes>
+ </configuration>
+ <executions>
+ <execution>
+ <id>clover-setup</id>
+ <phase>process-sources</phase>
+ <goals>
+ <goal>setup</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>clover</id>
+ <phase>test</phase>
+ <goals>
+ <goal>clover</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>sonar</id>
+ <properties>
+ <sonar.php.coverage.reportPaths>${project.build.directory}/clover/clover.xml</sonar.php.coverage.reportPaths>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.sonarsource.scanner.maven</groupId>
+ <artifactId>sonar-maven-plugin</artifactId>
+ </plugin>
+ </plugins>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.sonarsource.scanner.maven</groupId>
+ <artifactId>sonar-maven-plugin</artifactId>
+ <version>3.7.0.1746</version>
Review comment:
could make a property for the sonar maven plugin version? (similar to the clover maven plugin version)
##########
File path: pom.xml
##########
@@ -445,6 +445,97 @@
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
+ <profile>
+ <id>clover</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <property>
+ <name>clover</name>
+ </property>
+ </activation>
+ <properties>
+ <cloverDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverDatabase>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.openclover</groupId>
+ <artifactId>clover-maven-plugin</artifactId>
+ <configuration>
+ <includesAllSourceRoots>false</includesAllSourceRoots>
+ <includesTestSourceRoots>true</includesTestSourceRoots>
+ <cloverDatabase>${cloverDatabase}</cloverDatabase>
+ <targetPercentage>50%</targetPercentage>
+ <outputDirectory>${project.build.directory}/clover</outputDirectory>
+ <alwaysReport>true</alwaysReport>
+ <generateHistorical>false</generateHistorical>
+ <cloverDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverDatabase>
+ <cloverMergeDatabase>${project.build.directory}/clover/zookeeper-coverage.db</cloverMergeDatabase>
+ <outputDirectory>${project.build.directory}/clover</outputDirectory>
+ <generateHtml>true</generateHtml>
+ <generateXml>true</generateXml>
+ <includesAllSourceRoots>false</includesAllSourceRoots>
+ <includesTestSourceRoots>true</includesTestSourceRoots>
+ <includes>
+ <include>org/apache/zookeeper/**/*</include>
+ </includes>
+ <excludes>
+ <exclude>org/apache/zookeeper/version/**/*</exclude>
+ <exclude>**/ReadOnlyModeTest.java</exclude>
Review comment:
why are we exclude these (and only these) tests below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org