You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Vetrivel Chinnasamy <ve...@citrix.com> on 2014/05/26 08:50:21 UTC
Review Request 21901: L10N:001-Fixed the legacy hard-coding issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
-----------------------------------------------------------
Review request for cloudstack and Brian Federle.
Repository: cloudstack-git
Description
-------
Externalized the hard coded strings in JavaScript files and added them to messages.properties files. Also appended the link dictionary.jsp with the externalized strings.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties eff2c3e
systemvm/js/cloud.logger.js 751627e
ui/dictionary.jsp 9cc030a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/scripts/accounts.js a789084
ui/scripts/configuration.js 1a88224
ui/scripts/events.js 2731cb6
ui/scripts/network.js f934f21
ui/scripts/sharedFunctions.js 2cfc89f
ui/scripts/storage.js 2660aa5
ui/scripts/system.js 67e01f1
ui/scripts/templates.js 67cc2fb
ui/scripts/ui-custom/physicalResources.js 06fcca7
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui/dialog.js 34cec7b
ui/scripts/ui/widgets/listView.js be40d33
ui/scripts/vpc.js 020b9d7
Diff: https://reviews.apache.org/r/21901/diff/
Testing
-------
Tested in local environment by replacing the fixed file.
Thanks,
Vetrivel Chinnasamy
Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues
Posted by Gabor Apati-Nagy <ga...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/#review44724
-----------------------------------------------------------
I checked this diff and found the followings that need to be fixed before the change could be committed to the repo. Some of them make the UI not to load at all.
I suggest this to be checked again, I might have missed other typos.
There is an extra '=' character in the line added here:
@@ -107,7 +107,7 @@ angular.module("storage").controller("VolumesListCtrl", ["$scope", "$location",
{
model: 'format',
type: 'select',
- label: 'format',
+ label: 'label.format=',
There is a missing comma after <fmt:message key="message.confirm.disable.vpc.offering" />'
ui/dictionary.jsp:
@@ -1881,6 +1911,49 @@ dictionary = {
'message.enabling.vpc.offering': '<fmt:message key="message.enabling.vpc.offering" />',
'message.confirm.remove.vpc.offering': '<fmt:message key="message.confirm.remove.vpc.offering" />',
'message.confirm.disable.vpc.offering': '<fmt:message key="message.confirm.disable.vpc.offering" />'
-
+'label.add.ciscoASA1000v.resource': '<fmt:message key="label.add.ciscoASA1000v.resource" />',
+'label.delete.ciscoASA1000v': '<fmt:message key="label.delete.ciscoASA1000v" />',
+'message.confirm.delete.ciscoASA1000v': '<fmt:message key="message.confirm.delete.ciscoASA1000v" />',
There is also a comma missing after <fmt:message key="label.inside.port.profile" />'
There is an extra comma at the last item in dictionary.jsp.
At sharedFunctions.js the diff looks like:
- case 19:
- return "GPU";
+ return _l('label.secondary.storage.vm');
+- case 19:
+- return _l('label.gpu');
The problem above is the last two lines, it causes javascript syntax error, because also “-“ will be added to the js file.
Thanks
Gabor
- Gabor Apati-Nagy
On May 27, 2014, 11:58 a.m., Vetrivel Chinnasamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21901/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 11:58 a.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Externalized the hard coded strings in JavaScript files and added them to messages.properties files. Also appended the link dictionary.jsp with the externalized strings.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties eff2c3e
> systemvm/js/cloud.logger.js 751627e
> ui/dictionary.jsp 9cc030a
> ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
> ui/scripts/accounts.js a789084
> ui/scripts/configuration.js 1a88224
> ui/scripts/events.js 2731cb6
> ui/scripts/network.js f934f21
> ui/scripts/sharedFunctions.js 2cfc89f
> ui/scripts/storage.js 2660aa5
> ui/scripts/system.js 67e01f1
> ui/scripts/templates.js 67cc2fb
> ui/scripts/ui-custom/physicalResources.js 06fcca7
> ui/scripts/ui-custom/regions.js 986e009
> ui/scripts/ui/dialog.js 34cec7b
> ui/scripts/ui/widgets/listView.js be40d33
> ui/scripts/vpc.js 020b9d7
>
> Diff: https://reviews.apache.org/r/21901/diff/
>
>
> Testing
> -------
>
> Tested in local environment by replacing the fixed file.
>
>
> File Attachments
> ----------------
>
> Patch - 2 Commits
> https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch
>
>
> Thanks,
>
> Vetrivel Chinnasamy
>
>
Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
-----------------------------------------------------------
(Updated July 9, 2014, 2:38 p.m.)
Review request for cloudstack and Brian Federle.
Repository: cloudstack-git
Description
-------
Externalized the hard coded strings in JavaScript files and added them to messages.properties files. Also appended the link dictionary.jsp with the externalized strings.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties eff2c3e
systemvm/js/cloud.logger.js 751627e
ui/dictionary.jsp 9cc030a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/scripts/accounts.js a789084
ui/scripts/configuration.js 1a88224
ui/scripts/events.js 2731cb6
ui/scripts/network.js f934f21
ui/scripts/sharedFunctions.js 2cfc89f
ui/scripts/storage.js 2660aa5
ui/scripts/system.js 67e01f1
ui/scripts/templates.js 67cc2fb
ui/scripts/ui-custom/physicalResources.js 06fcca7
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui/dialog.js 34cec7b
ui/scripts/ui/widgets/listView.js be40d33
ui/scripts/vpc.js 020b9d7
Diff: https://reviews.apache.org/r/21901/diff/
Testing
-------
Tested in local environment by replacing the fixed file.
File Attachments
----------------
Patch - 2 Commits
https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch
Thanks,
Vetrivel Chinnasamy
Re: Review Request 21901: L10N:001-Fixed the legacy hard-coding issues
Posted by Vetrivel Chinnasamy <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21901/
-----------------------------------------------------------
(Updated May 27, 2014, 10:58 a.m.)
Review request for cloudstack and Brian Federle.
Changes
-------
This patch is created with below 2 commit diffs.
1) commit 0a1b98b1a9f715e91eaa4635c02374434da6d6ac
Author: vetrivelc <ve...@citrix.com>
Date: Tue May 27 13:21:04 2014 +0530
L10N:002-Fixed hardcoding issues
Signed-off-by: vetrivelc <ve...@citrix.com>
2) commit 987bd92922dd8c1e4138e9e31b53ba3dfae81a29
Author: vetrivelc <ve...@citrix.com>
Date: Fri May 23 21:48:30 2014 +0530
Fixed the hardcoding issues
Signed-off-by: vetrivelc <ve...@citrix.com>
Repository: cloudstack-git
Description
-------
Externalized the hard coded strings in JavaScript files and added them to messages.properties files. Also appended the link dictionary.jsp with the externalized strings.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties eff2c3e
systemvm/js/cloud.logger.js 751627e
ui/dictionary.jsp 9cc030a
ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a
ui/scripts/accounts.js a789084
ui/scripts/configuration.js 1a88224
ui/scripts/events.js 2731cb6
ui/scripts/network.js f934f21
ui/scripts/sharedFunctions.js 2cfc89f
ui/scripts/storage.js 2660aa5
ui/scripts/system.js 67e01f1
ui/scripts/templates.js 67cc2fb
ui/scripts/ui-custom/physicalResources.js 06fcca7
ui/scripts/ui-custom/regions.js 986e009
ui/scripts/ui/dialog.js 34cec7b
ui/scripts/ui/widgets/listView.js be40d33
ui/scripts/vpc.js 020b9d7
Diff: https://reviews.apache.org/r/21901/diff/
Testing
-------
Tested in local environment by replacing the fixed file.
File Attachments (updated)
----------------
Patch - 2 Commits
https://reviews.apache.org/media/uploaded/files/2014/05/27/4d2b3c2f-246b-49a6-a528-8c95eecbfba8__001002-L10N-Hardcoding_Fix.patch
Thanks,
Vetrivel Chinnasamy