Re: svn commit: r947672 - /qpid/trunk/qpid/java/module.xml

[Rajith Attapattu <ra...@gmail.com>]

This is a good change.
+1

Rajith

On Mon, May 24, 2010 at 11:38 AM,  <ro...@apache.org> wrote:
> Author: robbie
> Date: Mon May 24 15:38:58 2010
> New Revision: 947672
>
> URL: http://svn.apache.org/viewvc?rev=947672&view=rev
> Log:
> Enforce usage of the requested test profile by failing immediately if it isnt found, preventing a silent fallback to the default test profile.
>
> Modified:
>    qpid/trunk/qpid/java/module.xml
>
> Modified: qpid/trunk/qpid/java/module.xml
> URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/module.xml?rev=947672&r1=947671&r2=947672&view=diff
> ==============================================================================
> --- qpid/trunk/qpid/java/module.xml (original)
> +++ qpid/trunk/qpid/java/module.xml Mon May 24 15:38:58 2010
> @@ -260,7 +260,12 @@
>
>
>   <property name="profile" value="default"/>
> -  <property file="${test.profiles}/${profile}.testprofile" prefix="preload"/>
> +  <property name="testprofile.file" value="${test.profiles}/${profile}.testprofile"/>
> +
> +  <available file="${testprofile.file}" property="testprofile.file.present"/>
> +  <fail unless="testprofile.file.present" message="The requested test profile was not found: ${testprofile.file}"/>
> +
> +  <property file="${testprofile.file}" prefix="preload"/>
>   <property name="preload.include" value=""/>
>   <condition property="profiles"
>              value="${preload.include} ${profile}"
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:commits-subscribe@qpid.apache.org
>
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org