You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "Przemo Pakulski (JIRA)" <ji...@apache.org> on 2007/04/02 11:51:32 UTC

[jira] Created: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

BundleDBPersistenceManager does not free blobStore resources
------------------------------------------------------------

                 Key: JCR-832
                 URL: https://issues.apache.org/jira/browse/JCR-832
             Project: Jackrabbit
          Issue Type: Bug
          Components: core
    Affects Versions: 1.2.3
            Reporter: Przemo Pakulski


When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by Savas Triantafillou <sa...@gmail.com>.

Hi ,

do you know when the patch will be committed and
whether it is safe to use BundleBDPersistenceManager and
BundleFsPersistenceManager
as they are at the moment until this issue is resolved ?

Thank you,

Savvas

On 5/31/07, Przemo Pakulski (JIRA) <ji...@apache.org> wrote:
>
>
>      [
> https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Przemo Pakulski updated JCR-832:
> --------------------------------
>
>     Attachment: JCR-832-patch.txt
>
> Attached patch proposal. Abstract method destroy(PropertyState) added to
> AbstractBundlePM and called during store. Method implemented in BundleDB PM
> to ensure that blob resources are removed from underlying blobstore.
>
> Not sure if something needs to be done in BundleFS PM, so method remains
> empty there.
>
>
> > BundleDBPersistenceManager does not free blobStore resources
> > ------------------------------------------------------------
> >
> >                 Key: JCR-832
> >                 URL: https://issues.apache.org/jira/browse/JCR-832
> >             Project: Jackrabbit
> >          Issue Type: Bug
> >          Components: core
> >    Affects Versions: 1.3
> >            Reporter: Przemo Pakulski
> >            Assignee: Tobias Bocanegra
> >         Attachments: JCR-832-patch.txt
> >
> >
> > When removing binary property from node or removing node containing
> binary property, resources occupied by binary property are not freed
> (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Przemo Pakulski updated JCR-832:
--------------------------------

    Attachment: JCR-832-patch.txt

Attached patch proposal. Abstract method destroy(PropertyState) added to AbstractBundlePM and called during store. Method implemented in BundleDB PM to ensure that blob resources are removed from underlying blobstore.

Not sure if something needs to be done in BundleFS PM, so method remains empty there.


> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-832:
------------------------------

        Fix Version/s: 1.4
    Affects Version/s: 1.3.3

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>             Fix For: 1.4
>
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551721 ] 

Tobias Bocanegra commented on JCR-832:
--------------------------------------

right. since the handling of blobs is dependent of the bundlebinding i suggest to include this in the nodeprop bundles and let the 'destroy' method of the property entry free the resource. 

i will attach a patch.

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529247 ] 

Jukka Zitting commented on JCR-832:
-----------------------------------

Toby or Przemo, are you planning to act on this in near future? If not, I'll take over and commit the patch in a few days.

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3, 1.3.1
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>             Fix For: 1.3.2
>
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551750 ] 

Stefan Guggisberg commented on JCR-832:
---------------------------------------

yup, +1 for toby's patch

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt, jcr-832.patch
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Przemo Pakulski updated JCR-832:
--------------------------------

    Affects Version/s:     (was: 1.2.3)
                       1.3

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Przemo Pakulski
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551742 ] 

Jukka Zitting commented on JCR-832:
-----------------------------------

+1 That looks nice and clean!

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt, jcr-832.patch
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra updated JCR-832:
---------------------------------

    Attachment: jcr-832.patch

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt, jcr-832.patch
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503038 ] 

Jukka Zitting commented on JCR-832:
-----------------------------------

Looks good to me.

Przemo, feel free to commit this. (Though it would be nice if you used spaces instead of tabs.)


> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra resolved JCR-832.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

committed proposed patch @ revision 604211.

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>             Fix For: 1.4
>
>         Attachments: JCR-832-patch.txt, jcr-832.patch
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-832:
------------------------------

    Fix Version/s:     (was: 1.3.2)

This seems more complex than expected. There is already an existing "remove property" code path based on BLOBFileValue.remove(), but that doesn't work correctly for database persistence with externalBLOBs set to false because the BLOBFileValue.remove() call ends up removing the temporary copy of the value instead of the actual database row.

Instead of adding a new code path for handling database persistence, I'd rather have a way that hooks the required functionality to the existing code path.

Also, this issue might get obsoleted with the new data store feature.

Thus, I'm removing this issue from the 1.3.2 roadmap.

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-832:
------------------------------

    Fix Version/s:     (was: 1.4)

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.3, 1.3.1, 1.3.3
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-832:
------------------------------

        Fix Version/s: 1.3.2
    Affects Version/s: 1.3.1

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3, 1.3.1
>            Reporter: Przemo Pakulski
>            Assignee: Tobias Bocanegra
>             Fix For: 1.3.2
>
>         Attachments: JCR-832-patch.txt
>
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra reassigned JCR-832:
------------------------------------

    Assignee: Tobias Bocanegra

> BundleDBPersistenceManager does not free blobStore resources
> ------------------------------------------------------------
>
>                 Key: JCR-832
>                 URL: https://issues.apache.org/jira/browse/JCR-832
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Przemo Pakulski
>         Assigned To: Tobias Bocanegra
>
> When removing binary property from node or removing node containing binary property, resources occupied by binary property are not freed (orphaned records remains in associated ${schemaObjectPrefix}BINVAL table).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.