You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/09/18 10:36:03 UTC

[PR] CAMEL-24817: camel-elasticsearch/camel-opensearch - metadata hygiene (scroll-keep-alive description, deprecate maxRetryTimeout) [camel]

oscerd opened a new pull request, #26591:
URL: https://github.com/apache/camel/pull/26591

   ## What
   
   Metadata hygiene in `camel-elasticsearch` and `camel-opensearch` (main only).
   
   ### 1. Wrong scroll-keep-alive header description
   The `CamelElasticsearchScrollKeepAliveMs` / `CamelOpensearchScrollKeepAliveMs` header (`PARAM_SCROLL_KEEP_ALIVE_MS`) was documented as **"The starting index of the response."** — a copy/paste from the from/offset header. It now describes the scroll keep-alive window, matching the `scrollKeepAliveMs` endpoint option.
   
   ### 2. Deprecate the unused `maxRetryTimeout` option
   The `maxRetryTimeout` endpoint and component option is never read — it is a leftover from the old low-level Elasticsearch REST client's `setMaxRetryTimeoutMillis`, which no longer exists in the client these components use today, so setting it has no effect. It is now `@Deprecated` (kept in place for backward compatibility of existing endpoint URIs) with an upgrade-guide note.
   
   ## Changes
   
   - `ElasticsearchConstants` / `OpensearchConstants`: corrected header description.
   - `Elasticsearch/Opensearch Configuration` + `Component`: `@Deprecated` on the `maxRetryTimeout` field and getters/setters; `@SuppressWarnings("deprecation")` on `createEndpoint` (which copies the option while it still exists).
   - Regenerated component metadata, catalog and endpoint/component DSL builders.
   - Upgrade-guide note in `camel-4x-upgrade-guide-4_23.adoc`.
   
   ## Notes
   
   - No functional/behaviour change; metadata + deprecation only.
   - Main only (deprecation + upgrade guide); not backported.
   
   _Generated by Claude Code on behalf of Andrea Cosentino (@oscerd)._
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24817: camel-elasticsearch/camel-opensearch - metadata hygiene (scroll-keep-alive description, deprecate maxRetryTimeout) [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26591:
URL: https://github.com/apache/camel/pull/26591#issuecomment-5729135378

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `catalog/camel-catalog`
   - `components/camel-elasticsearch`
   - `components/camel-opensearch`
   - `docs`
   - `dsl/camel-componentdsl`
   - `dsl/camel-endpointdsl`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 14 tested, 23 compile-only — current: 10 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **37 affected modules** (current approach: 10).
   
   <details><summary>:warning: Modules only in Scalpel (27)</summary>
   
   - `apache-camel`
   - `camel-allcomponents`
   - `camel-catalog`
   - `camel-catalog-console`
   - `camel-catalog-maven`
   - `camel-catalog-suggest`
   - `camel-componentdsl`
   - `camel-endpointdsl`
   - `camel-endpointdsl-support`
   - `camel-itest`
   - `camel-jbang-core`
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-kamelet-main`
   - `camel-launcher`
   - `camel-report-maven-plugin`
   - `camel-route-parser`
   - `camel-yaml-dsl`
   - `camel-yaml-dsl-deserializers`
   - `camel-yaml-dsl-maven-plugin`
   - `coverage`
   - `docs`
   - `dummy-component`
   
   </details>
   
   **Skip-tests mode would test 14 modules** (6 direct + 8 downstream), **skip tests for 23** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (14)</summary>
   
   - `camel-catalog`
   - `camel-componentdsl`
   - `camel-elasticsearch`
   - `camel-endpointdsl`
   - `camel-jbang-mcp`
   - `camel-jbang-plugin-mcp`
   - `camel-jbang-plugin-route-parser`
   - `camel-jbang-plugin-tui`
   - `camel-jbang-plugin-validate`
   - `camel-launcher-container`
   - `camel-opensearch`
   - `camel-yaml-dsl-validator`
   - `camel-yaml-dsl-validator-maven-plugin`
   - `docs`
   
   </details>
   
   <details><summary>Modules with tests skipped (23)</summary>
   
   - `apache-camel`
   - `camel-allcomponents`
   - `camel-catalog-console`
   - `camel-catalog-maven`
   - `camel-catalog-suggest`
   - `camel-endpointdsl-support`
   - `camel-itest`
   - `camel-jbang-core`
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-kamelet-main`
   - `camel-launcher`
   - `camel-report-maven-plugin`
   - `camel-route-parser`
   - `camel-yaml-dsl`
   - `camel-yaml-dsl-deserializers`
   - `camel-yaml-dsl-maven-plugin`
   - `coverage`
   - `dummy-component`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   <details><summary>All tested modules (37 modules, 4m 52s total)</summary>
   
   **Total reactor time:** 4m 52s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: Launcher | 50.5s | SUCCESS |
   | Camel :: JBang :: MCP | 41.0s | SUCCESS |
   | Camel :: JBang :: Plugin :: TUI | 34.0s | SUCCESS |
   | Camel :: Component DSL | 30.6s | SUCCESS |
   | Camel :: Catalog :: Camel Catalog | 23.9s | SUCCESS |
   | Camel :: Docs | 15.6s | SUCCESS |
   | Camel :: JBang :: Plugin :: Kubernetes | 15.2s | SUCCESS |
   | Camel :: Kamelet Main | 9.5s | SUCCESS |
   | Camel :: YAML DSL :: Validator | 8.5s | SUCCESS |
   | Camel :: Catalog :: Camel Route Parser | 8.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: Testing | 7.8s | SUCCESS |
   | Camel :: YAML DSL :: Deserializers | 7.5s | SUCCESS |
   | Camel :: Catalog :: Camel Report Maven Plugin | 5.2s | SUCCESS |
   | Camel :: All Components Sync point | 5.2s | SUCCESS |
   | Camel :: JBang :: Plugin :: Validate | 5.1s | SUCCESS |
   | Camel :: YAML DSL :: Validator Maven Plugin | 3.8s | SUCCESS |
   | Camel :: YAML DSL :: Maven Plugins | 3.1s | SUCCESS |
   | Camel :: Catalog :: Maven | 2.6s | SUCCESS |
   | Camel :: Catalog :: Suggest (deprecated) | 2.4s | SUCCESS |
   | Camel :: Coverage | 1.9s | SUCCESS |
   | Camel :: Assembly | 1.8s | SUCCESS |
   | Camel :: JBang :: Plugin :: Edit | 1.4s | SUCCESS |
   | Camel :: JBang :: Integration tests | 1.1s | SUCCESS |
   | Camel :: JBang :: Plugin :: Generate | 1.0s | SUCCESS |
   | Camel :: Catalog :: Dummy Component | 0.9s | SUCCESS |
   | Camel :: Catalog :: Console | 0.8s | SUCCESS |
   | Camel :: JBang :: Main | 0.8s | SUCCESS |
   | Camel :: Endpoint DSL :: Support | 0.8s | SUCCESS |
   | Camel :: Launcher :: Container | 0.7s | SUCCESS |
   | Camel :: JBang :: Plugin :: MCP | 0.6s | SUCCESS |
   | Camel :: JBang :: Plugin :: Route Parser | 0.6s | SUCCESS |
   | Camel :: Elasticsearch Java API Client | n/a |  |
   | Camel :: Endpoint DSL | n/a |  |
   | Camel :: Integration Tests | n/a |  |
   | Camel :: JBang :: Core | n/a |  |
   | Camel :: OpenSearch Java API Client | n/a |  |
   | Camel :: YAML DSL | n/a |  |
   
   **Top 20 slowest modules:**
   - `Camel :: Launcher` (50.5s)
   - `Camel :: JBang :: MCP` (41.0s)
   - `Camel :: JBang :: Plugin :: TUI` (34.0s)
   - `Camel :: Component DSL` (30.6s)
   - `Camel :: Catalog :: Camel Catalog` (23.9s)
   - `Camel :: Docs` (15.6s)
   - `Camel :: JBang :: Plugin :: Kubernetes` (15.2s)
   - `Camel :: Kamelet Main` (9.5s)
   - `Camel :: YAML DSL :: Validator` (8.5s)
   - `Camel :: Catalog :: Camel Route Parser` (8.2s)
   - `Camel :: JBang :: Plugin :: Testing` (7.8s)
   - `Camel :: YAML DSL :: Deserializers` (7.5s)
   - `Camel :: Catalog :: Camel Report Maven Plugin` (5.2s)
   - `Camel :: All Components Sync point` (5.2s)
   - `Camel :: JBang :: Plugin :: Validate` (5.1s)
   - `Camel :: YAML DSL :: Validator Maven Plugin` (3.8s)
   - `Camel :: YAML DSL :: Maven Plugins` (3.1s)
   - `Camel :: Catalog :: Maven` (2.6s)
   - `Camel :: Catalog :: Suggest (deprecated)` (2.4s)
   - `Camel :: Coverage` (1.9s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35335499750)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24817: camel-elasticsearch/camel-opensearch - metadata hygiene (scroll-keep-alive description, deprecate maxRetryTimeout) [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #26591:
URL: https://github.com/apache/camel/pull/26591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24817: camel-elasticsearch/camel-opensearch - metadata hygiene (scroll-keep-alive description, deprecate maxRetryTimeout) [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26591:
URL: https://github.com/apache/camel/pull/26591#issuecomment-5728813917

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org