You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2009/09/25 02:36:15 UTC
[jira] Created: (CASSANDRA-457) web-based Cassandra browser
web-based Cassandra browser
---------------------------
Key: CASSANDRA-457
URL: https://issues.apache.org/jira/browse/CASSANDRA-457
Project: Cassandra
Issue Type: Improvement
Affects Versions: 0.5
Reporter: Jun Rao
Assignee: Jun Rao
A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-457:
-------------------------------------
Attachment: 457_v3.diff
Still not entirely sure whether this should be included or not.
In any case, I made things a little easier for me to evaluate. Hopefully they will make things easier for others as well.
* Included WSGI handler in addition to mod_python handling for easier integration with other Python HTTP components.
* Made the script executable using default wsgi server
* Simplified json imports
* Made mod_python form handling optional
* Attempted to add generated python code if deploying from svn or a release
With these changes, only the following is needed to run after applying the patch:
ant gen-thrift-py (if you haven't already)
./contrib/cassandra_browser/index.py (with optional --address localhost and --port 8111)
If you are running Python 2.6 and have the Thrift library installed, that's literally all that needs to be done. For other environments, you may need to install other components.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hernan Badenes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hernan Badenes updated CASSANDRA-457:
-------------------------------------
Comment: was deleted
(was: Replaces patchv2)
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763474#action_12763474 ]
Hudson commented on CASSANDRA-457:
----------------------------------
Integrated in Cassandra #221 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/221/])
cassandra client with a web-based interface
Patch by Jun Rao, Hernan Badenes, and Michael Greene;
reviewed by eevans for
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Hernan Badenes
> Fix For: 0.5
>
> Attachments: 457_v3.diff, 457_v4.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hernan Badenes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hernan Badenes updated CASSANDRA-457:
-------------------------------------
Attachment: 457_v4.diff
Patch to be applied over v3 version. It adds documentation about WSGI cmd line usage, and removes author names and IBM copyright notice.
Eric, could you please commit? Thank you.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, 457_v4.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated CASSANDRA-457:
------------------------------
Attachment: screenshot.pdf
Attach a screenshot that shows how it looks.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hernan Badenes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762709#action_12762709 ]
Hernan Badenes commented on CASSANDRA-457:
------------------------------------------
@Michael
I just had the time to test 457_v3.patch and I liked the WSGI handler addition. It is a good alternative for using it. I am no WSGI master either, all I can say is "it works".
The only thing I would add now is to add these two things to the README: The fact you need to gen-thrift-py (I had forgotted this, as I had this code already generated) and the command line wsgi launcher usage. (Let me know if you want me to write it).
Other than that I feel it's done; ready to be committed if you guys think it fits in contrib/. Opinions, objections?
Thanks, Hernan.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-457:
---------------------------------
Fix Version/s: 0.5
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Hernan Badenes
> Fix For: 0.5
>
> Attachments: 457_v3.diff, 457_v4.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-457:
-------------------------------------
Comment: was deleted
(was: Still not entirely sure whether this should be included or not.
In any case, I made things a little easier for me to evaluate. Hopefully they will make things easier for others as well.
* Included WSGI handler in addition to mod_python handling for easier integration with other Python HTTP components.
* Made the script executable using default wsgi server
* Simplified json imports
* Made mod_python form handling optional
* Attempted to add generated python code if deploying from svn or a release
With these changes, only the following is needed to run after applying the patch:
ant gen-thrift-py (if you haven't already)
./contrib/cassandra_browser/index.py (with optional --address localhost and --port 8111)
If you are running Python 2.6 and have the Thrift library installed, that's literally all that needs to be done. For other environments, you may need to install other components.)
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-457:
-------------------------------------
Attachment: 457_v3.diff
Still not entirely sure whether this should be included or not.
In any case, I made things a little easier for me to evaluate. Hopefully they will make things easier for others as well. I'm no WSGI master so go easy.
* Included WSGI handler in addition to mod_python handling for easier integration with other Python HTTP components.
* Made the script executable using default wsgi server
* Simplified json imports
* Made mod_python form handling optional
* Attempted to add generated python code if deploying from svn or a release
With these changes, only the following is needed to run after applying the patch:
ant gen-thrift-py (if you haven't already)
cd contrib/cassandra_browser
python index.py (with optional --address localhost and --port 8111)
If you are running Python 2.6 and have the Thrift library installed, that's literally all that needs to be done. For other environments, you may need to install other components.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-457:
-------------------------------------
Attachment: (was: 457_v3.diff)
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762741#action_12762741 ]
Michael Greene commented on CASSANDRA-457:
------------------------------------------
No, my only objection at this point is that I'd like to write something at another level, a la Couch's Futon, but my laziness shouldn't hold back Hernan's excellent work.
Hernan: Thanks for the feedback, glad you can run it. Would you mind updating the README?
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762714#action_12762714 ]
Jun Rao commented on CASSANDRA-457:
-----------------------------------
>From the mailing list, it seems this browser-based interface could be useful for others. So, I'd recommend putting in under contrib, unless there is an objection.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759654#action_12759654 ]
Eric Evans commented on CASSANDRA-457:
--------------------------------------
I'm of the opinion that we should be pretty liberal about adding stuff to contrib/, so while I have a few comments regarding this patch, the only one I consider to be blocking is the included copy of simplejson. We really should avoid embedding third-party libraries whenever possible, and it doesn't seem warranted here (it's easy enough to install simplejson separately).
As for the other (non-blocking) comments:
It's always a good idea to use WSGI when creating Python web applications, but having chosen to use mod python instead, there are some features you could exploit to make this a little less brittle and a little easier to maintain.
For example, instead of mixing html in with the rest of the code, you could use PSP (http://www.modpython.org/live/current/doc-html/pyapi-psp.html).
Instead of hard-coding things like host, port, and keyspace, you could make them configurable via the apache configuration using PythonOption directives.
Instead of coding up all of your own form handling, you could take advantage of mod python's (http://www.modpython.org/live/current/doc-html/pyapi-util-fstor.html).
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hernan Badenes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760422#action_12760422 ]
Hernan Badenes commented on CASSANDRA-457:
------------------------------------------
Thank you Eric and Michael for your comments. I applied most of your suggestions:
- used 'try import json; except ...'. We were using simplejson as 'json' is not available in all systems; but the inclusion on this patch was unintentional. There is an annotation in the README on how to obtain json or simplejson libraries, so that should be enough.
- we changed form processing to use FieldStorage. This simplified the code very nicely.
- also moved the default values to settings you can pass with PythonOptions through server's mod_python.
- I also cleaned up the code a little -- but it is still written "a la publisher" way (not PSP). Doing it with PSP is feasible... but I also like how publisher handles things -- a middle ground would be great, though I am not sure how to implement this. In any case I don't have such a strong opinion on using either of the approaches, so if you have it and think that changing it is a must, please let me know.
I have just uploaded a new version intended to replace the v1 patch.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated CASSANDRA-457:
------------------------------
Attachment: issue457.patchv1
This is a simple, but useful web-based browser for Cassandra.
It offers the following features:
* form-based interface
* browse columns in a column family, including pagination of results
* all queries are based on URL parameters; so they can be bookmarked in a browser for re-querying later.
* view detailed data on any column
* certain types of data are annotated:
- Timestamps are shown both as decimal and as date/time.
- JSON strings are parsed and pretty-printed, with syntax highlighting, including parsing of nested elements (See the included cutejson library)
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-457) web-based Cassandra browser
Posted by "Hernan Badenes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hernan Badenes updated CASSANDRA-457:
-------------------------------------
Attachment: issue457.patchv2
Replaces patchv2
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759716#action_12759716 ]
Michael Greene commented on CASSANDRA-457:
------------------------------------------
I'm with Eric on the simplejson removal and would also prefer WSGI especially as it's fairly easy to code a main() to run for development that way.
try:
import json
except:
import simplejson as json
Additionally, I'm not so sure this belongs in contrib/ instead of its own project since it depends on another language and could be developed at a much faster pace elsewhere. However, if we're considering it more of an example/ of Thrift interface use then it makes sense.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: issue457.patchv1, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-457) web-based Cassandra browser
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762745#action_12762745 ]
Eric Evans commented on CASSANDRA-457:
--------------------------------------
I would commit 457_v3.diff as-is, but it contains a "(c)Copyright IBM Corp. 2009" footer on the webpage that I am fairly certain is blocking for legal reasons.
Hernan, if you can strip that out or replace "IBM Corp." with "Apache Software Foundation", I'd be happy to commit, (and of course Jun doesn't need anyone's help to commit :).
While you're in there, there are several author attributions (things like "written by: ....") that might not be blocking (for contrib anyway), but are against project policy. It'd be great if those could be stripped out as well.
> web-based Cassandra browser
> ---------------------------
>
> Key: CASSANDRA-457
> URL: https://issues.apache.org/jira/browse/CASSANDRA-457
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Jun Rao
> Assignee: Jun Rao
> Attachments: 457_v3.diff, issue457.patchv1, issue457.patchv2, screenshot.pdf
>
>
> A web-based interface that simplifies accessing cassandra through thrift.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.