You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2012/06/21 18:41:43 UTC
[jira] [Commented] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
[ https://issues.apache.org/jira/browse/LUCENE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398566#comment-13398566 ]
Michael McCandless commented on LUCENE-4162:
--------------------------------------------
+1 thanks Uwe!
> MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
> ----------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4162
> URL: https://issues.apache.org/jira/browse/LUCENE-4162
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.0, 5.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Critical
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4162.patch
>
>
> We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
> Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org